legacy_test:main on i386
ClosedPublic
Actions

Authored by ngie on Jul 3 2016, 1:59 AM.

Details

Reviewers

cem

Summary

Fix .../usr.bin/lastcomm/legacy_test:main on i386

The time in the output files was ahead by 3 hours on i386. Fix the incorrect
offset.

While here, make a minor change to output the diffs to standard error so the
issues with the results are apparent when running kyua debug,
kyua report-html, etc.

MFC after: 1 week
PR: 210329
Reported by: asomers
Sponsored by: EMC / Isilon Storage Division

Test Plan

$ sudo kyua test -k /usr/tests/usr.bin/lastcomm/Kyuafile legacy_test:main
legacy_test:main -> passed [0.047s]

Results file id is usr_tests_usr.bin_lastcomm.20160703-015834-353248
Results saved to /root/.kyua/store/results.usr_tests_usr.bin_lastcomm.20160703-015834-353248.db

1/1 passed (0 failed)
$ uname -a
FreeBSD fbsd11-i386.local 11.0-ALPHA5 FreeBSD 11.0-ALPHA5 #1 r301745+978d049(master): Thu Jun 30 18:03:32 PDT 2016 ngie@fbsd11-i386.local:/usr/obj/usr/src/git/sys/GENERIC i386

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4422
Build 4472: arc lint + arc unit

Event Timeline

ngie updated this revision to Diff 18102.Jul 3 2016, 1:59 AM

ngie retitled this revision from to Fix .../usr.sbin/lastcomm/legacy_test:main on i386.

ngie updated this object.

ngie edited the test plan for this revision. (Show Details)

ngie added subscribers: asomers, cem, markj.

Herald added a subscriber: imp. · View Herald TranscriptJul 3 2016, 1:59 AM

Remove usr.bin/lastcomm/lastcomm.c change from diff

ngie retitled this revision from Fix .../usr.sbin/lastcomm/legacy_test:main on i386 to Fix .../usr.bin/lastcomm/legacy_test:main on i386.Jul 3 2016, 2:04 AM

ngie updated this object.

ngie added a subscriber: emaste.

cem accepted this revision.Jul 3 2016, 2:35 AM

cem added a reviewer: cem.

This revision is now accepted and ready to land.Jul 3 2016, 2:35 AM

rS302326 and rS302327.