Page MenuHomeFreeBSD
Differential D6884

x11-wm/xfce4-session: Add support for i3lock to xflock4
ClosedPublic
Actions

Authored by woodsb02 on Jun 17 2016, 6:26 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Dec 18, 10:17 AM
Unknown Object (File)
Nov 26 2024, 1:39 PM
Unknown Object (File)
Nov 26 2024, 1:39 PM
Unknown Object (File)
Nov 26 2024, 1:39 PM
Unknown Object (File)
Nov 26 2024, 1:39 PM
Unknown Object (File)
Nov 25 2024, 6:38 AM
Unknown Object (File)
Oct 21 2024, 8:09 AM
Unknown Object (File)
Oct 2 2024, 4:48 PM
View All 77 Files
Subscribers
sbruno

Details

Reviewers
adamw
koobs
sbruno
mat
Group Reviewers
xfce
Commits
rP417036: x11-wm/xfce4-session:
Summary

x11-wm/xfce4-session:

  • Update patch-scripts_xflock4 to add support for x11/i3lock
Test Plan

poudriere testport x11-wm/xfce4-session

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

woodsb02 updated this revision to Diff 17669.Jun 17 2016, 6:26 PM
woodsb02 retitled this revision from to x11-wm/xfce4-session: Add support for i3lock to xflock4.
woodsb02 updated this object.
woodsb02 edited the test plan for this revision. (Show Details)
woodsb02 added reviewers: mat, adamw, koobs.
woodsb02 added a reviewer: xfce.Jun 17 2016, 6:26 PM
woodsb02 added a project: xfce.
sbruno accepted this revision.Jun 17 2016, 6:58 PM
sbruno added a reviewer: sbruno.
sbruno added a subscriber: sbruno.

stlgtm

This revision is now accepted and ready to land.Jun 17 2016, 6:58 PM
adamw added inline comments.Jun 17 2016, 7:25 PM
x11-wm/xfce4-session/files/patch-scripts_xflock4
8 ↗(On Diff #17669)

Hardcoding /usr/local isn't ideal. Can you add a fix for that to the patch please, Ben?

woodsb02 updated this revision to Diff 17674.Jun 17 2016, 8:49 PM
woodsb02 edited edge metadata.

As per comment from adamw:

  • Do not hard code /usr/local/bin in a patch; replace with %%LOCALBASE%%/bin
This revision now requires review to proceed.Jun 17 2016, 8:49 PM
adamw accepted this revision.Jun 17 2016, 8:50 PM
adamw edited edge metadata.

Thanks Ben

This revision is now accepted and ready to land.Jun 17 2016, 8:50 PM
woodsb02 marked an inline comment as done.Jun 17 2016, 8:50 PM
mat requested changes to this revision.Jun 17 2016, 9:12 PM
mat edited edge metadata.

You'll need to bump PORTREVISION so that people get the corrected version.

This revision now requires changes to proceed.Jun 17 2016, 9:12 PM
Closed by commit rP417036: x11-wm/xfce4-session: (authored by woodsb02). · Explain WhyJun 17 2016, 9:16 PM
This revision was automatically updated to reflect the committed changes.
woodsb02 added a comment.Jun 17 2016, 9:21 PM
In D6884#144477, @mat wrote:

You'll need to bump PORTREVISION so that people get the corrected version.

Sorry mat, this comment came through just prior to my commit, but I didn't see it.

Fixed in https://svnweb.freebsd.org/ports?view=revision&revision=417037

Revision Contents
Changeset List

PathSize
head/
x11-wm/
xfce4-session/
4 lines
files/
16 lines

Diff 17675

View Options

head/x11-wm/xfce4-session/Makefile

Loading...
View Options

head/x11-wm/xfce4-session/files/patch-scripts_xflock4

Loading...