Page MenuHomeFreeBSD

libefi only use waitforkeys if available
ClosedPublic

Authored by manu on Jun 9 2016, 12:27 AM.

Details

Summary

Only use WaitForKeys event if it exists, this is not the case in u-boot efi implementation.

Test Plan

Tested on beaglebone black with u-boot efi implementation.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu retitled this revision from to libefi only use waitforkeys if available.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added a reviewer: andrew.
manu set the repository for this revision to rS FreeBSD src repository - subversion.

This looks correct, but add some UEFI people to check. On U-Boot WaitForKey is NULL.

sys/boot/efi/libefi/efi_console.c
442 ↗(On Diff #17445)

This check should be against zero since this isn't a bool or even a pointer.

sys/boot/efi/libefi/efi_console.c
442 ↗(On Diff #17445)

From sys/boot/efi/include/efidef.h :
typedef VOID *EFI_EVENT;

So I should check against NULL.

manu edited edge metadata.

Check against NULL

jhb edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2016, 5:03 PM
emaste edited edge metadata.

LGTM. Perhaps worth a comment in the source referencing u-boot UEFI as an example of an impl. lacking WaitForEvent?

This revision was automatically updated to reflect the committed changes.