Page MenuHomeFreeBSD
Differential D6781

libefi only use waitforkeys if available
ClosedPublic
Actions

Authored by manu on Jun 9 2016, 12:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 18, 2:10 AM
Unknown Object (File)
Sun, Oct 12, 6:39 PM
Unknown Object (File)
Sat, Oct 11, 10:07 PM
Unknown Object (File)
Fri, Oct 10, 3:05 AM
Unknown Object (File)
Sat, Oct 4, 6:24 AM
Unknown Object (File)
Sat, Sep 27, 3:58 AM
Unknown Object (File)
Tue, Sep 23, 1:47 AM
Unknown Object (File)
Sat, Sep 20, 11:29 PM
View All 94 Files
Subscribers
imp

Details

Reviewers
emaste
jhb
andrew
imp
smh
Commits
rS304222: Only use WaitForKeys event if it exists, this is not the case in u-boot efi…
Summary

Only use WaitForKeys event if it exists, this is not the case in u-boot efi implementation.

Test Plan

Tested on beaglebone black with u-boot efi implementation.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu updated this revision to Diff 17445.Jun 9 2016, 12:27 AM
manu retitled this revision from to libefi only use waitforkeys if available.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added a reviewer: andrew.
manu set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJun 9 2016, 12:27 AM
andrew added reviewers: smh, emaste, jhb, imp.Jun 9 2016, 12:37 AM

This looks correct, but add some UEFI people to check. On U-Boot WaitForKey is NULL.

imp added inline comments.Jun 9 2016, 2:28 AM
sys/boot/efi/libefi/efi_console.c
442 ↗(On Diff #17445)

This check should be against zero since this isn't a bool or even a pointer.

manu added inline comments.Jun 9 2016, 12:52 PM
sys/boot/efi/libefi/efi_console.c
442 ↗(On Diff #17445)

From sys/boot/efi/include/efidef.h :
typedef VOID *EFI_EVENT;

So I should check against NULL.

manu updated this revision to Diff 17460.Jun 9 2016, 12:55 PM
manu edited edge metadata.

Check against NULL

jhb accepted this revision.Jun 15 2016, 5:03 PM
jhb edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2016, 5:03 PM
emaste accepted this revision.Jun 15 2016, 5:33 PM
emaste edited edge metadata.

LGTM. Perhaps worth a comment in the source referencing u-boot UEFI as an example of an impl. lacking WaitForEvent?

Closed by commit rS304222: Only use WaitForKeys event if it exists, this is not the case in u-boot efi… (authored by manu). · Explain WhyAug 16 2016, 2:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
boot/
efi/
libefi/
9 lines

Diff 19353

View Options

head/sys/boot/efi/libefi/efi_console.c

Loading...