Fix circular dependency created after r287197 between ldconfig and mountcritremote

[ngie]

Summary

Fix circular dependency created after r287197 between ldconfig and mountcritremote

ldconfig is already required by mountcritremote indirectly, as noted by rcorder:

rcorder: Circular dependency on provision mountcritremote' in file ldconfig'.

Having mountcritremote REQUIRE ldconfig breaks dependency ordering.

Making the ldconfig hints be conditionally regenerated from mountcritremote when
remote filesystems are mounted is done after this change, similar to cleanvar
being conditionally called after the change.

PR: 202726
Sponsored by: EMC / Isilon Storage Division

Test Plan

• Booted systems multiple times successfully, with NFS mounted late, and not.

Before change:

% rcorder /etc/rc.d/* | awk '/ldconfig|mount.*/ { print NR, $NF }'
rcorder: Circular dependency on provision mountcritremote' in file /etc/rc.d/ldconfig'.
14 /etc/rc.d/mountcritlocal
34 /etc/rc.d/ldconfig
54 /etc/rc.d/mountcritremote
85 /etc/rc.d/mountd
97 /etc/rc.d/mountlate

After change:

% rcorder /etc/rc.d/* | awk '/ldconfig|mount.*/ { print NR, $NF }'
14 /etc/rc.d/mountcritlocal
34 /etc/rc.d/ldconfig
54 /etc/rc.d/mountcritremote
85 /etc/rc.d/mountd
97 /etc/rc.d/mountlate

[jilles]

Looks good to me.

On another note, it would be nice to check for circular dependencies during the build; this is made harder by rcorder being written in C.