Page MenuHomeFreeBSD

Add compat/top/FREEBSD-upgrade
ClosedPublic

Authored by rwestlun_gmail.com on May 22 2016, 7:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 12 2024, 2:16 PM
Unknown Object (File)
Nov 20 2023, 6:38 AM
Unknown Object (File)
Nov 13 2023, 12:36 PM
Unknown Object (File)
Nov 10 2023, 3:29 AM
Unknown Object (File)
Nov 7 2023, 11:13 AM
Unknown Object (File)
Nov 6 2023, 6:42 PM
Unknown Object (File)
Nov 6 2023, 6:46 AM
Unknown Object (File)
Nov 4 2023, 4:33 AM
Subscribers
None

Details

Reviewers
ngie
Summary

The readme provides a high-level overview of how to upgrade top(1).

MFC after: 1 week
Submitted by: Randy Westlund <rwestlun@gmail.com>
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rwestlun_gmail.com retitled this revision from to Add compat/top/FREEBSD-upgrade.
rwestlun_gmail.com updated this object.
rwestlun_gmail.com edited the test plan for this revision. (Show Details)
rwestlun_gmail.com added a reviewer: ngie.
rwestlun_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.

Update notes with a description of our local changes to top(1), and what it will take to apply it to 3.8-beta1.

Update with details about changes that have been made and what still needs resolving.

The goal of the FREEBSD-upgrade file is to provide a means for tersely describing where the project came from, and where one can bootstrap source for the next upgrade.

contrib/top/FREEBSD-upgrade
3

*regarding

8

It probably should be top, not Top.

88

This doesn't seem appropriate for this file; this does however seem incredibly relevant for release notes and/or a commit message for the 3.8b1 upgrade.

100–114

Were these changes already present in 3.5, or were they made directly to 3.8?

117–168

Again, this seems like something that should be on a wiki page instead of being put here.

rwestlun_gmail.com added inline comments.
contrib/top/FREEBSD-upgrade
88

I wasn't sure where else to put it for the time being. I can move it to a different file, only on my machine.

100–114

They were part of our local patch set. I re-implemented them for the new version. I'll clarify that.

rwestlun_gmail.com edited edge metadata.

Address comments, remove sections that belong somewhere else.

Just to be clear, these directions should *only* refer to what is done for 3.5. In particular, using the example I provided earlier (atf [1]), it only provides high-level directions for how the autoconf stuff was generated. I can obtain a diff between the vendor source and the source in the tree -- why do our modifications need to be itemized in such granular detail? This makes the document more likely become stale in the future.

https://svnweb.freebsd.org/base/head/contrib/atf/FREEBSD-upgrade?revision=272056&view=markup

contrib/top/FREEBSD-upgrade
21–37

Isn't this portion for the next version?

88

Please -- alternatively, this can go on a FreeBSD wiki page so it can be edited more easily, and potentially used as a checklist for items that need to be done.

  • Remove overly detailed patch descriptions.
  • Remove directions that only apply to 3.8 until the new version is ready.

Ok, much better.. walking through the changes between the vendor tree and ^/head/contrib/top, there are some files that have been renamed:

  • contrib/top/top.X -> contrib/top/top.xs
  • contrib/top/top.local.H -> contrib/top/top.local.hs

If you document those -- I'll commit the read me.

Oops, I removed a bit too much. Add back a note about the files that were renamed.

contrib/top/FREEBSD-upgrade
15–20

This block is unnecessary. Please remove.

25–26

I would probably erase this sentence. It should be clear from usr.bin/top/Makefile that contrib/top/Configure and contrib/top/Makefile.X isn't used.

28–29

*were renamed

Changes made. Thanks for being patient and all the feedback.

ngie edited edge metadata.

Changes made. Thanks for being patient and all the feedback.

LGTM!

This revision is now accepted and ready to land.May 26 2016, 5:35 AM
ngie edited edge metadata.
ngie removed subscribers: doceng, imp.