That covers it, thanks!

Oh, that's much more detailed. Also untouched for two years...

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212514

It passes poudriere testing. Is there anything else that needs fixing before it gets committed?

In D7818#162383, @mat wrote:

Mmmm, I do not know what it does, and I thought I had deprecated that...
Like I said, if you want to do the testing yourself (and not use poudriere to do it) add DEVELOPER=yes to your /etc/make.conf, and run make like you always do.

Extraneous variable removed.

Thanks for the feedback, this is much cleaner. Once this is approved, I'll clean up the port I copied this from.

Reworded to avoid starting a sentence with a <filename> tag.

You're correct, the revision I was using was before your other changes went in. With r303462 and this patch, the tests pass successfully for me :)

I'm using 12-CURRENT r303286, and setting the sysctl vfs.aio.enable_unsafe=1 to enable the tests.

Changes made. Thanks for being patient and all the feedback.

Oops, I removed a bit too much. Add back a note about the files that were renamed.

• Remove overly detailed patch descriptions.
• Remove directions that only apply to 3.8 until the new version is ready.

Address comments, remove sections that belong somewhere else.

Update with details about changes that have been made and what still needs resolving.

Update notes with a description of our local changes to top(1), and what it will take to apply it to 3.8-beta1.

Updated to address comments:

• Copy license to new header files.
• Add __unused to a parameter.
• Label two functions as static.
• Remove extraneous space and newline.
• Remove register from new code.

In D6468#136976, @cem wrote:

This program could use ANSIfication of function definitions and a liberal dosing of style(9). That can wait for a later cleanup, though.

Regenerated with svn diff --diff-cmd=diff -x -U999999