Add compat/top/FREEBSD-upgrade

[rwestlun_gmail.com]

Summary

The readme provides a high-level overview of how to upgrade top(1).

MFC after: 1 week
Submitted by: Randy Westlund <[e-mail]>
Sponsored by: EMC / Isilon Storage Division

[rwestlun_gmail.com]

Update notes with a description of our local changes to top(1), and what it will take to apply it to 3.8-beta1.

[rwestlun_gmail.com]

Update with details about changes that have been made and what still needs resolving.

[ngie]

The goal of the FREEBSD-upgrade file is to provide a means for tersely describing where the project came from, and where one can bootstrap source for the next upgrade.

contrib/top/FREEBSD-upgrade

3 ↗

(On Diff #16839)

*regarding

8 ↗

(On Diff #16839)

It probably should be top, not Top.

88 ↗

(On Diff #16839)

This doesn't seem appropriate for this file; this does however seem incredibly relevant for release notes and/or a commit message for the 3.8b1 upgrade.

100–114 ↗

(On Diff #16839)

Were these changes already present in 3.5, or were they made directly to 3.8?

117–168 ↗

(On Diff #16839)

Again, this seems like something that should be on a wiki page instead of being put here.

[rwestlun_gmail.com]

contrib/top/FREEBSD-upgrade

88 ↗

(On Diff #16839)

I wasn't sure where else to put it for the time being. I can move it to a different file, only on my machine.

100–114 ↗

(On Diff #16839)

They were part of our local patch set. I re-implemented them for the new version. I'll clarify that.

[rwestlun_gmail.com]

Address comments, remove sections that belong somewhere else.

[ngie]

Just to be clear, these directions should *only* refer to what is done for 3.5. In particular, using the example I provided earlier (atf [1]), it only provides high-level directions for how the autoconf stuff was generated. I can obtain a diff between the vendor source and the source in the tree -- why do our modifications need to be itemized in such granular detail? This makes the document more likely become stale in the future.

https://svnweb.freebsd.org/base/head/contrib/atf/FREEBSD-upgrade?revision=272056&view=markup

contrib/top/FREEBSD-upgrade

20–36 ↗

(On Diff #16844)

Isn't this portion for the next version?

88 ↗

(On Diff #16839)

Please -- alternatively, this can go on a FreeBSD wiki page so it can be edited more easily, and potentially used as a checklist for items that need to be done.

[rwestlun_gmail.com]

• Remove overly detailed patch descriptions.
• Remove directions that only apply to 3.8 until the new version is ready.

[ngie]

Ok, much better.. walking through the changes between the vendor tree and ^/head/contrib/top, there are some files that have been renamed:

• contrib/top/top.X -> contrib/top/top.xs
• contrib/top/top.local.H -> contrib/top/top.local.hs

If you document those -- I'll commit the read me.

[rwestlun_gmail.com]

Oops, I removed a bit too much. Add back a note about the files that were renamed.

[ngie]

contrib/top/FREEBSD-upgrade

14–19 ↗

(On Diff #16852)

This block is unnecessary. Please remove.

24–25 ↗

(On Diff #16852)

I would probably erase this sentence. It should be clear from usr.bin/top/Makefile that contrib/top/Configure and contrib/top/Makefile.X isn't used.

27–28 ↗

(On Diff #16852)

*were renamed

[rwestlun_gmail.com]

Changes made. Thanks for being patient and all the feedback.

[ngie]

In D6493#138805, @rwestlun_gmail.com wrote:

Changes made. Thanks for being patient and all the feedback.

LGTM!

[ngie]

Committed as https://svnweb.freebsd.org/changeset/base/300714 .