Make code compile when basename() is POSIX compliant.
ClosedPublic
Actions

Authored by ed on May 19 2016, 7:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 15, 5:02 AM

	Unknown Object (File)
	Wed, Jan 8, 11:43 AM

	Unknown Object (File)
	Fri, Jan 3, 6:56 PM

	Unknown Object (File)
	Tue, Dec 24, 8:28 AM

	Unknown Object (File)
	Nov 29 2024, 8:31 PM

	Unknown Object (File)
	Nov 21 2024, 10:53 PM

	Unknown Object (File)
	Sep 18 2024, 5:27 AM

	Unknown Object (File)
	Sep 12 2024, 6:38 PM

View All 39 Files

Subscribers

imp

Details

Reviewers

emaste
bdrewery

Commits

rS300227: Make code compile when basename() is POSIX compliant.

Summary

If basename() uses "char *", we shouldn't do the intermediate
assignment, as that field is of type "const char *". Simply call
basename() on the command line argument directly.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3836
Build 3879: arc lint + arc unit

Event Timeline

ed updated this revision to Diff 16582.May 19 2016, 7:49 PM

ed retitled this revision from to Make code compile when basename() is POSIX compliant..

ed updated this object.

ed edited the test plan for this revision. (Show Details)

ed added reviewers: emaste, bdrewery.

Herald added a subscriber: imp. · View Herald TranscriptMay 19 2016, 7:49 PM

ELF Tool Chain ar.c already has this form.

This revision is now accepted and ready to land.May 19 2016, 7:58 PM

Closed by commit rS300227: Make code compile when basename() is POSIX compliant. (authored by ed). · Explain WhyMay 19 2016, 8:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.bin/

ar/

ar.c

4 lines

Diff 16582

View Options

Make code compile when basename() is POSIX compliant.ClosedPublicActions