Page MenuHomeFreeBSD

Avoid issuing spa config updates for physical path when not necessary
ClosedPublic

Authored by asomers on May 17 2016, 10:41 PM.

Details

Summary

ZFS's configuration needs to be updated whenever the physical path for a
device changes, but not when a new device is introduced. This is because
new devices necessarily cause config updates, but only if they are actually
accepted into the pool.

sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c

  • Split vdev_geom_set_physpath out of vdev_geom_attrchanged
  • When setting the vdev's physical path, only request a config
	  update if the physical path has changed.  Don't request it when
	  opening a device for the first time, because the config sync will
	  happen anyway upstack.

sys/geom/geom_dev.c

  • Split g_dev_set_physpath and g_dev_set_media out of
	  g_dev_attrchanged

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3795
Build 3838: arc lint + arc unit

Event Timeline

asomers updated this revision to Diff 16489.May 17 2016, 10:41 PM
asomers retitled this revision from to Avoid issuing spa config updates for physical path when not necessary.
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added reviewers: avg, smh, delphij.

Any objections?

This revision was automatically updated to reflect the committed changes.