Initial bhnd(4) SPROM/NVRAM support.

[landon_landonf.org]

Summary

This adds support for the NVRAM handling and the basic SPROM
hardware used on siba(4) and bcma(4) devices, including:

• SPROM directly attached to the PCI core, accessible via PCI configuration space.
• SPROM attached to later ChipCommon cores.
• SPROM variables vended from the parent SoC bus (e.g. via a directly-attached flash device).

Additional improvements to the NVRAM/SPROM interface will
be required, but this changeset stands alone as working
checkpoint.

Depends on D6195

Test Plan

Load if_bwn_pci and look for a valid Broadcom MAC address:

bwn0: got macaddr 8c:2d:aa:36:5f:07

[landon_landonf.org]

Minor spelling fix.

[landon_landonf.org]

Optimize NVRAM table lookup, rebase against master.

• Fix generation of struct variable records.
• Implement a stable sorting guarantee for the generated NVRAM table.
• Use the variable table order guarantee to implement binary search for variable definitions.

[landon_landonf.org]

mizkha: when you get a chance, can you eyeball this for any issues on the SoC side?

[mizhka]

sys/dev/bhnd/cores/chipc/chipc.c

196–198 ↗

(On Diff #15959)

I think if sprom is unsupported, it shouldn't cause fail of chipc attach call.

sys/dev/bhnd/nvram/nvram_subr.c

48–54 ↗

(On Diff #15959)

CRC8 polinom is duplicated few times in kernel. May be to add generic support?

[landon_landonf.org]

• Add support for generating a set of #defines for all bhnd(4) NVRAM variable keys.
• Allow ChipCommon to attach when OTP or NFLASH SPROM sources are identified.
• Rename the bhnd_nvram_* variable functions (modeled on the OF_prop* API).
• When generating nvram map headers, truncate any existing output file.
• Add an explicit fallback cases for unmatched enums.
• Re-integrate module dependency that went missing in a merge.

[landon_landonf.org]

sys/dev/bhnd/cores/chipc/chipc.c

196–198 ↗

(On Diff #15959)

Makes sense; the unhandled sources will now just print a message, rather than breaking attach.

sys/dev/bhnd/nvram/nvram_subr.c

48–54 ↗

(On Diff #15959)

I think the only other code using these same crc8 parameters is in the siba code we're replacing.

[emaste]

/scratch/tmp/emaste/freebsd/sys/modules/bhnd/bhndb_pci/../../../dev/bhnd/bhndb/bhndb_pci.c:170:52: error: format specifies type 'size_t' (aka 'unsigned int') but the argument has type 'bus_size_t' (aka 'unsigned long') [-Werror,-Wformat]
                        device_printf(dev, "found SPROM (%zu bytes)\n", nv_sz);
                                                         ~~~            ^~~~~
                                                         %lu
/scratch/tmp/emaste/freebsd/sys/modules/bhnd/bhndb_pci/../../../dev/bhnd/bhndb/bhndb_pci.c:237:1: error: conflicting types for 'bhndb_pci_sprom_size'
bhndb_pci_sprom_size(struct bhndb_pci_softc *sc)
^
/scratch/tmp/emaste/freebsd/sys/modules/bhnd/bhndb_pci/../../../dev/bhnd/bhndb/bhndb_pci.c:76:16: note: previous declaration is here
static size_t           bhndb_pci_sprom_size(struct bhndb_pci_softc *sc);
                        ^
2 errors generated.

[adrian]

Fixing it now

-a