Page MenuHomeFreeBSD

Stop DDB from printing unneeded stack traces on command line parsing errors
Needs ReviewPublic

Authored by dan_partelly_rdsor.ro on Apr 30 2016, 10:38 AM.

Details

Reviewers
pfg
Summary

Stops DDB from annyingly print a stack trace on command line parse error.
Behaviour in the cases when a trace is desirable in unchanged.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3519
Build 3559: arc lint + arc unit

Event Timeline

dan_partelly_rdsor.ro retitled this revision from to Stop DDB from printing unneeded stack traces on command line parsing errors.
dan_partelly_rdsor.ro updated this object.
dan_partelly_rdsor.ro edited the test plan for this revision. (Show Details)
dan_partelly_rdsor.ro added a reviewer: pfg.
dan_partelly_rdsor.ro added a subscriber: jhb.

Perhaps you can minimize the change by renaming kdb_reenter to _kdb_reenter() and having 'kdb_reenter()' call '_kdb_reenter(true)' and 'db_error()' call '_kdb_reenter(false)'? In general I don't think other places that call kdb_reenter() should have to think about specifying the 'print_trace' arg. I think it's fine if they just use 'db_error()' or 'kdb_reenter()' depending on the situation.

Ok, Ill look at your suggestions and have an updated diff soon.