Differential D59853

aq: Report partial initialization failures to iflib
ClosedPublic
Actions

Authored by kbowling on Sun, Sep 20, 12:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 12, 12:38 PM

	Unknown Object (File)
	Mon, Oct 12, 12:37 PM

	Unknown Object (File)
	Sun, Oct 11, 1:27 PM

	Unknown Object (File)
	Sat, Oct 3, 8:05 PM

	Unknown Object (File)
	Sat, Oct 3, 10:50 AM

	Unknown Object (File)
	Sat, Oct 3, 12:08 AM

	Unknown Object (File)
	Fri, Oct 2, 1:58 PM

	Unknown Object (File)
	Tue, Sep 29, 10:04 PM

View All 36 Files

Subscribers

Details

Reviewers

• nprice
nick_spun.io

Commits

rGdfe2ff8fd33f: aq: Report partial initialization failures to iflib
rG050683bb8e13: aq: Report partial initialization failures to iflib

Summary

Stop initialization when hardware setup, ring initialization/start, or
datapath start fails. Run the existing best-effort stop/cache/reset
cleanup and report the failure through iflib_init_failed(). Do not keep
configuring later rings or publish the interface as running.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kbowling created this revision.Sun, Sep 20, 12:42 AM

Herald added a subscriber: imp. · View Herald TranscriptSun, Sep 20, 12:42 AM

kbowling requested review of this revision.Sun, Sep 20, 12:42 AM

Whoops, we should definitely be bailing out in these spots, good catch!

This revision is now accepted and ready to land.Fri, Sep 25, 5:03 AM

Closed by commit rG050683bb8e13: aq: Report partial initialization failures to iflib (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyFri, Sep 25, 5:13 AM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG050683bb8e13: aq: Report partial initialization failures to iflib.

emaste added a commit: rGdfe2ff8fd33f: aq: Report partial initialization failures to iflib.Mon, Oct 12, 3:29 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

aq/

19 lines

Diff 187646

sys/dev/aq/aq_main.c

Loading...