Page MenuHomeFreeBSD
Differential D5973

Fix the 'type' for a few variables from tcpcb.
ClosedPublic
Actions

Authored by hiren on Apr 15 2016, 7:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 20 2024, 1:28 AM
Unknown Object (File)
Oct 4 2024, 6:02 AM
Unknown Object (File)
Sep 25 2024, 5:52 PM
Unknown Object (File)
Sep 23 2024, 1:16 AM
Unknown Object (File)
Sep 22 2024, 7:58 PM
Unknown Object (File)
Sep 20 2024, 11:27 PM
Unknown Object (File)
Sep 20 2024, 10:35 PM
Unknown Object (File)
Sep 18 2024, 2:29 AM
View All 87 Files
Subscribers
DTrace

Details

Reviewers
markj
gnn
Group Reviewers
manpages
Commits
rS298087: Fix the 'type' for a few variables from tcpcb.
Summary

Fix the 'type' for a few variables from tcpcb.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3291
Build 3325: arc lint + arc unit

Event Timeline

hiren updated this revision to Diff 15251.Apr 15 2016, 7:20 PM
hiren retitled this revision from to Fix the 'type' for a few variables from tcpcb..
hiren updated this object.
hiren edited the test plan for this revision. (Show Details)
hiren added reviewers: markj, gnn.
Herald edited edge metadata. · View Herald TranscriptApr 15 2016, 7:20 PM
Herald added a subscriber: imp. · View Herald Transcript
hiren edited edge metadata.Apr 15 2016, 7:21 PM
hiren edited subscribers, added: DTrace; removed: imp.
markj edited edge metadata.Apr 15 2016, 7:25 PM

Could you update dtrace_tcp.4 as well? Thanks!

hiren updated this revision to Diff 15252.Apr 15 2016, 7:32 PM
hiren edited edge metadata.

Address comments by @markj to update the manpage.

Herald added a reviewer: manpages. · View Herald TranscriptApr 15 2016, 7:32 PM
markj accepted this revision.Apr 15 2016, 8:02 PM
markj edited edge metadata.

This looks ok to me. (The man page probably should have a .Dd update.)

The point of the translator is to provide compatibility with other operating systems that implement this provider (Solaris, OS X), but D scripts generally won't care about integer widths, so I don't think this minor deviation is a problem. That said, are you doing this because one of the fields is actually getting truncated? Or did you just notice a mismatch?

This revision is now accepted and ready to land.Apr 15 2016, 8:02 PM
hiren added a comment.Apr 15 2016, 8:08 PM
In D5973#127283, @markj wrote:

This looks ok to me. (The man page probably should have a .Dd update.)

Thanks, updated the date for commit.

The point of the translator is to provide compatibility with other operating systems that implement this provider (Solaris, OS X), but D scripts generally won't care about integer widths, so I don't think this minor deviation is a problem. That said, are you doing this because one of the fields is actually getting truncated? Or did you just notice a mismatch?

I am seeing some weirdness with cwnd under/over-flowing in our code and while trying to use dtrace I noticed the type mismatch.

Closed by commit rS298087: Fix the 'type' for a few variables from tcpcb. (authored by hiren). · Explain WhyApr 15 2016, 8:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cddl/
lib/
libdtrace/
8 lines

Diff 15251

View Options

cddl/lib/libdtrace/tcp.d

Loading...