Page MenuHomeFreeBSD

Fix the 'type' for a few variables from tcpcb.
ClosedPublic

Authored by hiren on Apr 15 2016, 7:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 3, 9:15 PM
Unknown Object (File)
Thu, Oct 2, 6:09 PM
Unknown Object (File)
Thu, Oct 2, 2:17 AM
Unknown Object (File)
Wed, Oct 1, 3:50 AM
Unknown Object (File)
Tue, Sep 30, 9:31 PM
Unknown Object (File)
Mon, Sep 22, 11:35 AM
Unknown Object (File)
Sep 1 2025, 2:07 AM
Unknown Object (File)
Aug 29 2025, 6:22 AM
Subscribers

Details

Summary

Fix the 'type' for a few variables from tcpcb.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hiren retitled this revision from to Fix the 'type' for a few variables from tcpcb..
hiren updated this object.
hiren edited the test plan for this revision. (Show Details)
hiren added reviewers: markj, gnn.
hiren edited subscribers, added: DTrace; removed: imp.

Could you update dtrace_tcp.4 as well? Thanks!

hiren edited edge metadata.

Address comments by @markj to update the manpage.

markj edited edge metadata.

This looks ok to me. (The man page probably should have a .Dd update.)

The point of the translator is to provide compatibility with other operating systems that implement this provider (Solaris, OS X), but D scripts generally won't care about integer widths, so I don't think this minor deviation is a problem. That said, are you doing this because one of the fields is actually getting truncated? Or did you just notice a mismatch?

This revision is now accepted and ready to land.Apr 15 2016, 8:02 PM
In D5973#127283, @markj wrote:

This looks ok to me. (The man page probably should have a .Dd update.)

Thanks, updated the date for commit.

The point of the translator is to provide compatibility with other operating systems that implement this provider (Solaris, OS X), but D scripts generally won't care about integer widths, so I don't think this minor deviation is a problem. That said, are you doing this because one of the fields is actually getting truncated? Or did you just notice a mismatch?

I am seeing some weirdness with cwnd under/over-flowing in our code and while trying to use dtrace I noticed the type mismatch.

This revision was automatically updated to reflect the committed changes.