Page MenuHomeFreeBSD

ipfilter: fix inverted range check on the lookup iterator unit
Needs ReviewPublic

Authored by markj on Wed, Sep 16, 12:32 PM.
Tags
None
Referenced Files
F172222655: D59726.id186849.diff
Thu, Sep 17, 12:05 AM
F172219516: D59726.diff
Wed, Sep 16, 11:17 PM
Unknown Object (File)
Wed, Sep 16, 1:30 PM
Unknown Object (File)
Wed, Sep 16, 1:30 PM

Details

Reviewers
cy
Summary

ipf_lookup_iterate() validates iter.ili_unit with

if (iter.ili_unit < IPL_LOGALL && iter.ili_unit > IPL_LOGMAX)

or alternatively,

if (iter.ili_unit < -1 && iter.ili_unit > 7)

ipf_lookup_add(), ipf_lookup_delete(), ipf_lookup_stats()
ipf_lookup_flush() validate with a ||

Submitted by calif.io for the OpenAI Patch The Planet program

Signed-off-by: Andrew Griffiths <andrew@calif.io>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76972
Build 73855: arc lint + arc unit