acpi_cpu: only report unmapped processor objects enabled in the MADT
ClosedPublic
Actions

Authored by seuros on Wed, Sep 9, 10:13 PM.

Details

Reviewers

imp
adrian
olce
jhb

Commits

rG9a46a1439c46: acpi_cpu: only report unmapped processor objects enabled in the MADT

Summary

Firmware expose a DSDT sized for the largest SKU of the platform,
so a verbose boot prints an "ignored" line for every vacant
processor slot. A vacant slot has no enabled MADT entry; a CPU that
failed to come online does.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

seuros requested review of this revision.Wed, Sep 9, 10:13 PM

seuros created this revision.

Harbormaster completed remote builds in B76720: Diff 186310.Wed, Sep 9, 10:13 PM

what platform did you see this on?

AMD64 , Raptor Lake+

Oldest machine are offline, so i didn't check.

I'd suggest some function renames, but otherwise looks fine. I might do some followup changes.

sys/dev/acpica/acpi_cpu.c
166	Suggested better name. Also, I'd remove the `p` in the name, and since it's an internal function, possible the full `acpi_cpu` prefix as well. Applicable as well to the other added function.
167	See previous inline comment.