Differential D59336

ixl: Reset VSI statistics after initial sampling
ClosedPublic
Actions

Authored by kbowling on Sep 3 2026, 10:58 AM.

Tags

None

Referenced Files

	F174571618: D59336.id185787.diff
	Sun, Oct 4, 7:06 AM

	Unknown Object (File)
	Sat, Oct 3, 4:03 AM

	Unknown Object (File)
	Thu, Oct 1, 3:49 AM

	Unknown Object (File)
	Sat, Sep 26, 12:46 PM

	Unknown Object (File)
	Sat, Sep 26, 4:59 AM

	Unknown Object (File)
	Thu, Sep 24, 7:30 PM

	Unknown Object (File)
	Wed, Sep 23, 10:48 PM

	Unknown Object (File)
	Wed, Sep 23, 10:29 AM

View All 47 Files

Subscribers

Details

Reviewers

Group Reviewers

Intel Networking
Restricted Owners Package	(Owns No Changed Paths)

Commits

rG930464eecabe: ixl: Reset VSI statistics after initial sampling
rG171d62055532: ixl: Reset VSI statistics after initial sampling
rG429cb537015e: ixl: Reset VSI statistics after initial sampling

Summary

The initial statistics update runs before the PF VSI has obtained its
firmware-assigned statistics counter index.  Discard that provisional
VSI baseline so the first update after initialization records the
correct hardware counter.

Without this reset, subtracting a larger provisional value from a newly
selected counter can be mistaken for a 32-bit wrap and report nearly
UINT32_MAX receive drops immediately after boot.

Reported by:    Daniel Braniss <danny@cs.huji.ac.il>
Obtained from:  Intel ixl 1.14.2
MFC after:      2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kbowling created this revision.Sep 3 2026, 10:58 AM

Owners added a reviewer: Restricted Owners Package.Sep 3 2026, 10:58 AM

Herald added subscribers: ae, imp. · View Herald TranscriptSep 3 2026, 10:58 AM

kbowling requested review of this revision.Sep 3 2026, 10:58 AM

kbowling added a child revision: D59337: ixl: Tie statistics baselines to hardware resource epochs.Sep 3 2026, 11:00 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 4 2026, 1:52 AM

Closed by commit rG429cb537015e: ixl: Reset VSI statistics after initial sampling (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG429cb537015e: ixl: Reset VSI statistics after initial sampling.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG171d62055532: ixl: Reset VSI statistics after initial sampling.Fri, Sep 18, 12:11 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG930464eecabe: ixl: Reset VSI statistics after initial sampling.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixl/

1 line

Diff 185787

sys/dev/ixl/if_ixl.c

Loading...