bsd.init.mk: always define _gid when MK_INSTALL_AS_USER is set

[fuz]

Summary

A recent commit started to use _uid and _gid in <bsd.dirs.mk> to
mangle the user and group for newly installed directories when
MK_INSTALL_AS_USER is set. However, _gid was previously only set
when _uid was not 0, causing the group to be set to the empty
string.

Set _uid and _gid together to avoid this problem.

Fixes: 541e6e2d516b6c9d3681b24464e9ef53c1f2579a
PR: 297841
Reported by: Ralph Zitz <[e-mail]>
MFC after: 1 week

Test Plan

port security/unix-selfauth-helper builds fine as root following this change.

[emaste]

Looks fine, but shouldn't this and bsd.dirs.mk have the same (${_uid} != 0) logic?

[fuz]

@emaste Sounds like a reasonable idea. I'll wait for @imp to decide as he came up with the logic in the first place.

[imp]

I have this in my tree too, but I've not had time to test it out. If you do, then I think it's the right thing :)

[emaste]

Any comment on the other question @imp? I.e., why don't we use .if ${_uid} != 0 in bsd.dirs.mk also?

[imp]

In D59150#1356945, @emaste wrote:

Any comment on the other question @imp? I.e., why don't we use .if ${_uid} != 0 in bsd.dirs.mk also?

Both should always be defined. I didn't see that one had better behavior (or different) than the other.

[fuz]

In D59150#1356946, @imp wrote:

In D59150#1356945, @emaste wrote:

Any comment on the other question @imp? I.e., why don't we use .if ${_uid} != 0 in bsd.dirs.mk also?

Both should always be defined. I didn't see that one had better behavior (or different) than the other.

I think @emaste's question is more about whether bsd.dirs.mk should also special case ${_uid} == 0 and then not change the uid and gid of installed directories when you are root but supply MK_INSTALL_AS_USER as we do in bsd.init.mk.

[imp]

In D59150#1357225, @fuz wrote:

In D59150#1356946, @imp wrote:

In D59150#1356945, @emaste wrote:

Any comment on the other question @imp? I.e., why don't we use .if ${_uid} != 0 in bsd.dirs.mk also?

Both should always be defined. I didn't see that one had better behavior (or different) than the other.

I think @emaste's question is more about whether bsd.dirs.mk should also special case ${_uid} == 0 and then not change the uid and gid of installed directories when you are root but supply MK_INSTALL_AS_USER as we do in bsd.init.mk.

It's a more orthogonal design, but I do see the point, despite it not being name MK_INSTALL_AS_USER_UNLESS_ROOT... I'm honestly not sure why we have this check here, honestly, and don't think it should be both places.