Page MenuHomeFreeBSD
Differential D5861

multimedia/x264: add FFMS and LSMASH options
ClosedPublic
Actions

Authored by jbeich on Apr 6 2016, 2:37 PM.
Tags
None
Referenced Files
F108476900: D5861.id14934.diff
Sat, Jan 25, 7:48 AM
Unknown Object (File)
Fri, Jan 17, 11:15 PM
Unknown Object (File)
Fri, Jan 17, 7:24 PM
Unknown Object (File)
Fri, Jan 17, 12:44 PM
Unknown Object (File)
Sat, Jan 11, 11:00 PM
Unknown Object (File)
Sat, Jan 11, 10:50 PM
Unknown Object (File)
Sat, Jan 11, 7:49 PM
Unknown Object (File)
Dec 25 2024, 3:19 PM
View All Files
Subscribers
mat

Details

Reviewers
koobs
Commits
rP414335: multimedia/x264: add r413181 caveat into UPDATING
rP413181: multimedia/x264: add FFMS and LSMASH options
Summary

FFMS supports only input, LSMASH - only output.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 3161
Build 3194: arc lint + arc unit

Event Timeline

jbeich updated this revision to Diff 14929.Apr 6 2016, 2:37 PM
jbeich retitled this revision from to multimedia/x264: add FFMS and LSMASH options.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: koobs.
Herald added a subscriber: mat. · View Herald TranscriptApr 6 2016, 2:37 PM
jbeich added a parent revision: D5860: multimedia/x264: make options actually affect dependencies.Apr 6 2016, 2:43 PM
jbeich added a comment.Apr 6 2016, 3:21 PM

Err, while GPAC and LSMASH options don't conflict there maybe no need to have both enabled by default. Note, l-smash has a vapoursynth plugin (to be in ports soon) and boasts:

# /usr/local/libdata/pkgconfig/liblsmash.pc
Description: Loyal to Spec of MPEG4, and Ad-hock Simple Hackwork
jbeich updated this revision to Diff 14934.Apr 6 2016, 3:29 PM

Oops, they do conflict. When both are selected vendor configure prefers LSMASH.

jbeich updated this revision to Diff 14935.Apr 6 2016, 3:59 PM

Missed _EXCLUDE in libx264 and converted to OPTIONS_RADIO.

jbeich updated this revision to Diff 14939.Apr 6 2016, 4:14 PM

Rebase

jbeich updated this revision to Diff 14941.Apr 6 2016, 5:17 PM

FFMS=on didn't work with --disable-swscale from LAVF=off. I've split it into a separate SWSCALE option via _IMPLIES.

jbeich updated this revision to Diff 14943.Apr 6 2016, 5:47 PM

Typo. FFMS_IMPLIES, not LSMASH_IMPLIES.

Closed by commit rP413181: multimedia/x264: add FFMS and LSMASH options (authored by jbeich). · Explain WhyApr 13 2016, 9:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
multimedia/
libx264/
2 lines
x264/
19 lines

Diff 14939

View Options

multimedia/libx264/Makefile

Loading...
View Options

multimedia/x264/Makefile

Loading...