Page MenuHomeFreeBSD

multimedia/x264: add FFMS and LSMASH options
ClosedPublic

Authored by jbeich on Apr 6 2016, 2:37 PM.

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbeich retitled this revision from to multimedia/x264: add FFMS and LSMASH options.Apr 6 2016, 2:37 PM
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: koobs.
jbeich updated this revision to Diff 14929.
jbeich added a comment.Apr 6 2016, 3:21 PM

Err, while GPAC and LSMASH options don't conflict there maybe no need to have both enabled by default. Note, l-smash has a vapoursynth plugin (to be in ports soon) and boasts:

# /usr/local/libdata/pkgconfig/liblsmash.pc
Description: Loyal to Spec of MPEG4, and Ad-hock Simple Hackwork
jbeich updated this revision to Diff 14934.Apr 6 2016, 3:29 PM

Oops, they do conflict. When both are selected vendor configure prefers LSMASH.

jbeich updated this revision to Diff 14935.Apr 6 2016, 3:59 PM

Missed _EXCLUDE in libx264 and converted to OPTIONS_RADIO.

jbeich updated this revision to Diff 14941.Apr 6 2016, 5:17 PM

FFMS=on didn't work with --disable-swscale from LAVF=off. I've split it into a separate SWSCALE option via _IMPLIES.

jbeich updated this revision to Diff 14943.Apr 6 2016, 5:47 PM

Typo. FFMS_IMPLIES, not LSMASH_IMPLIES.

This revision was automatically updated to reflect the committed changes.