stat.2: enhance the description of st_blocks
ClosedPublic
Actions

Authored by kib on Aug 2 2026, 2:59 PM.

Details

Reviewers

emaste
mckusick

Commits

rG4c58eef12d30: stat.2: enhance the description of st_blocks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 2 2026, 2:59 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptAug 2 2026, 2:59 PM

kib requested review of this revision.Aug 2 2026, 2:59 PM

markmi_dsl-only.net added a subscriber: markmi_dsl-only.net.Aug 2 2026, 4:44 PM

markmi_dsl-only.net added inline comments.

lib/libsys/stat.2
268	For [no "e"]?

kib marked an inline comment as done.Aug 2 2026, 4:47 PM

Does:
. . .
STANDARDS

The stat() and fstat() system calls are expected to conform to IEEE Std
1003.1-1990 (“POSIX.1”).  The fstatat() system call follows The Open
Group Extended API Set 2 specification.

. . .

need any related wording about extensions or aspects not covered by POSIX for the likes of fstat?

In D58592#1344688, @markmi_dsl-only.net wrote:
Does:
. . .
STANDARDS
The stat() and fstat() system calls are expected to conform to IEEE Std
1003.1-1990 (“POSIX.1”).  The fstatat() system call follows The Open
Group Extended API Set 2 specification.
. . .

need any related wording about extensions or aspects not covered by POSIX for the likes of fstat?

Why would it need it? Extensions are common and expected, why there would we need to talk specially about them?
Repeating the terms of the standard, we would need to update that with each new revision (and nobody would remember to do that).

This update looks good. It preserves expected behavior for filesystem-based objects and allows and explains how to interpret block size units for memory-based objects.

This revision is now accepted and ready to land.Aug 2 2026, 9:36 PM

emaste added inline comments.Aug 2 2026, 9:59 PM