Page MenuHomeFreeBSD
Differential D58550

amd64: try to fix the build with old clang that does not know about FRED
ClosedPublic
Actions

Authored by kib on Thu, Jul 30, 9:48 AM.
Tags
None
Referenced Files
F164555663: D58550.diff
Sun, Aug 2, 2:00 AM
F164524478: D58550.diff
Sat, Aug 1, 6:51 PM
Unknown Object (File)
Thu, Jul 30, 4:53 PM
Unknown Object (File)
Thu, Jul 30, 10:04 AM
Subscribers
imp

Details

Reviewers
jhb
jrtc27
Commits
rG72952bf6a307: amd64: try to fix the build with old clang that does not know about FRED

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Thu, Jul 30, 9:48 AM
Herald added a subscriber: imp. · View Herald TranscriptThu, Jul 30, 9:48 AM
kib requested review of this revision.Thu, Jul 30, 9:48 AM
kib added a reviewer: jrtc27.Thu, Jul 30, 10:22 AM
jrtc27 added inline comments.Thu, Jul 30, 10:38 AM
sys/amd64/amd64/exception.S
1406

(or <= 18; 19 has FRED support, which is good given that's the system toolchain on a bunch of recent FreeBSD releases)

1410–1412

This is a thing you can do apparently, who knew

kib updated this revision to Diff 183095.Thu, Jul 30, 10:55 AM
kib marked 2 inline comments as done.

clang <= 18.
.err for non-ax.

jrtc27 added a comment.Thu, Jul 30, 10:58 AM

Looks like phab mangled my tabs so the updated lines are all using spaces :(

kib updated this revision to Diff 183096.Thu, Jul 30, 11:04 AM

tabs not spaces

jrtc27 accepted this revision.Thu, Jul 30, 11:18 AM
jrtc27 added inline comments.
sys/amd64/amd64/exception.S
1407

Still missing tabs in the two gaps here, otherwise LGTM

1409

(I don't know if the right style would be to put a tab here like you've done for .byte or to leave it as a lone space? Both seem fine to me, but just pointing it out in case it hasn't occurred to you and you have a preference)

This revision is now accepted and ready to land.Thu, Jul 30, 11:18 AM
kib updated this revision to Diff 183097.Thu, Jul 30, 11:21 AM
kib marked 2 inline comments as done.

Use tabs after .if/.err

This revision now requires review to proceed.Thu, Jul 30, 11:21 AM
jrtc27 added inline comments.Thu, Jul 30, 11:36 AM
sys/amd64/amd64/exception.S
1407

(still not fixed)

kib marked an inline comment as done.Thu, Jul 30, 11:42 AM
kib added inline comments.
sys/amd64/amd64/exception.S
1407

It is already inconsistent. At least PROTF_ENTRY uses spaces. But ok.

kib updated this revision to Diff 183098.Thu, Jul 30, 11:43 AM
kib marked an inline comment as done.

More tabs.

jrtc27 accepted this revision.Thu, Jul 30, 12:03 PM

Thanks

sys/amd64/amd64/exception.S
1407

Oh, well, that may be true, I was just comparing against erets/eretu which had tabs, as did lkgs for your original patch

This revision is now accepted and ready to land.Thu, Jul 30, 12:03 PM
jhb accepted this revision.Thu, Jul 30, 12:43 PM

Thanks for fixing this so quickly!

Closed by commit rG72952bf6a307: amd64: try to fix the build with old clang that does not know about FRED (authored by kib). · Explain WhyThu, Jul 30, 5:09 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG72952bf6a307: amd64: try to fix the build with old clang that does not know about FRED.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
17 lines

Diff 183117

View Options

sys/amd64/amd64/exception.S

Loading...