malloc: Fix domainset usage in malloc_domainset() for large allocs
ClosedPublic
Actions

Authored by markj on Fri, Jul 17, 9:13 PM.

Details

Reviewers

alc
rlibby

Commits

rG0aca7ce7af35: malloc: Fix domainset usage in malloc_domainset() for large allocs

Summary

We should of course pass the provided domainset rather than copying what
plain malloc() does.

Fixes: 89deca0a3361 ("malloc: make malloc_large closer to standalone")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Fri, Jul 17, 9:13 PM

Herald added subscribers: olce, imp. · View Herald TranscriptFri, Jul 17, 9:13 PM

markj requested review of this revision.Fri, Jul 17, 9:13 PM

markj added a parent revision: D58272: malloc: Refactor redzone and KASAN handling.

Harbormaster completed remote builds in B74903: Diff 182160.Fri, Jul 17, 9:13 PM

Maybe one day we should plumb it for malloc_dbg / memguard_alloc too.

This revision is now accepted and ready to land.Fri, Jul 17, 9:22 PM

In D58316#1337411, @rlibby wrote:

Maybe one day we should plumb it for malloc_dbg / memguard_alloc too.

Do you use memguard at all? I haven't needed to reach for it since KASAN was added.

In D58316#1337420, @markj wrote:

In D58316#1337411, @rlibby wrote:

Maybe one day we should plumb it for malloc_dbg / memguard_alloc too.

Do you use memguard at all? I haven't needed to reach for it since KASAN was added.

Yes, though maybe there's a better way to do what we're doing. memguard can be used with only small performance impact for types/zones that don't match vm.memguard.desc. Actually I was recently thinking about a way to use memguard more broadly for infrequent allocations.

Closed by commit rG0aca7ce7af35: malloc: Fix domainset usage in malloc_domainset() for large allocs (authored by markj). · Explain WhyFri, Jul 31, 1:30 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG0aca7ce7af35: malloc: Fix domainset usage in malloc_domainset() for large allocs.