Page MenuHomeFreeBSD

ee: Improve handling of malformed UTF-8 characters
AcceptedPublic

Authored by markj on Wed, Jul 1, 4:46 PM.
Tags
None
Referenced Files
F161707077: D57996.id181185.diff
Mon, Jul 6, 3:24 AM
Unknown Object (File)
Sat, Jul 4, 3:44 AM
Unknown Object (File)
Fri, Jul 3, 10:17 AM
Unknown Object (File)
Fri, Jul 3, 10:09 AM
Subscribers

Details

Reviewers
bapt
des
Summary

In delete(), when copying the deleted character to the d_char buffer,
don't assume that it fits. utf8_prev() may return a sequence of more
than 5 bytes.

In insert_utf8(), fix the copy-up of the line. We extended the line by
"len" bytes, so "temp" has to be repositioned accordingly. Compare with
plain insert().

Use sizeof when copying to buffers instead of hard-coding buffer sizes.

Don't dynamically allocate d_char, there is no need.

Fixes: 62fba0054d9e ("ee: add unicode support")
Reported by: Sayono Hiragi (overflow in delete())

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74465
Build 71348: arc lint + arc unit