Page MenuHomeFreeBSD

ee: Improve handling of malformed UTF-8 characters
ClosedPublic

Authored by markj on Jul 1 2026, 4:46 PM.
Tags
None
Referenced Files
F171672215: D57996.id181185.diff
Sat, Sep 12, 2:16 PM
Unknown Object (File)
Fri, Sep 11, 1:40 AM
Unknown Object (File)
Thu, Sep 10, 9:46 PM
Unknown Object (File)
Thu, Sep 10, 2:27 PM
Unknown Object (File)
Wed, Sep 9, 11:05 AM
Unknown Object (File)
Tue, Sep 8, 8:35 PM
Unknown Object (File)
Tue, Sep 8, 8:35 PM
Unknown Object (File)
Tue, Sep 8, 4:07 PM
Subscribers

Details

Summary

In delete(), when copying the deleted character to the d_char buffer,
don't assume that it fits. utf8_prev() may return a sequence of more
than 5 bytes.

In insert_utf8(), fix the copy-up of the line. We extended the line by
"len" bytes, so "temp" has to be repositioned accordingly. Compare with
plain insert().

Use sizeof when copying to buffers instead of hard-coding buffer sizes.

Don't dynamically allocate d_char, there is no need.

Fixes: 62fba0054d9e ("ee: add unicode support")
Reported by: Sayono Hiragi (overflow in delete())

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable