dtrace: Fix DOF section bounds validation
ClosedPublic
Actions

Authored by markj on Tue, Jun 30, 9:13 PM.

Details

Reviewers

gnn
christos

Group Reviewers

DTrace

Commits

rG8dc98f4d25a3: dtrace: Fix DOF section bounds validation

Summary

We must ensure that each DOF section does not overlap with the DOF
header or section table. Otherwise the relocations processed in the
second pass over sections can manipulate DOF metadata, leading to OOB
writes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Tue, Jun 30, 9:13 PM

Herald added a reviewer: gnn. · View Herald TranscriptTue, Jun 30, 9:13 PM

Herald added a subscriber: imp. · View Herald Transcript

markj requested review of this revision.Tue, Jun 30, 9:13 PM

markj added a parent revision: D57975: dtrace: Improve DOF section size validation.

markj added a child revision: D57977: dtrace: Improve DOF string table validation.

Harbormaster completed remote builds in B74433: Diff 181116.Tue, Jun 30, 9:13 PM

christos accepted this revision.Thu, Jul 2, 3:37 PM

This revision is now accepted and ready to land.Thu, Jul 2, 3:37 PM

Closed by commit rG8dc98f4d25a3: dtrace: Fix DOF section bounds validation (authored by markj). · Explain WhyMon, Jul 6, 1:28 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG8dc98f4d25a3: dtrace: Fix DOF section bounds validation.

Revision Contents
Changeset List

Path

Size

sys/

cddl/

contrib/

opensolaris/

uts/

common/

dtrace/

dtrace.c

12 lines

Diff 181352

View Options

sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c

dtrace: Fix DOF section bounds validationClosedPublicActions