dtrace: Improve DOF section size validation
ClosedPublic
Actions

Authored by markj on Tue, Jun 30, 9:13 PM.

Details

Reviewers

gnn
christos

Group Reviewers

DTrace

Commits

rGc1b6ebc2b758: dtrace: Improve DOF section size validation

Summary

The loop which validates each DOF section assumes that the section
header is present, so the section size must be at least as large as the
header, otherwise a small OOB access is possible.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Tue, Jun 30, 9:13 PM

Herald added a reviewer: gnn. · View Herald TranscriptTue, Jun 30, 9:13 PM

Herald added a subscriber: imp. · View Herald Transcript

markj requested review of this revision.Tue, Jun 30, 9:13 PM

Harbormaster completed remote builds in B74432: Diff 181115.Tue, Jun 30, 9:13 PM

markj added a child revision: D57976: dtrace: Fix DOF section bounds validation.Tue, Jun 30, 9:13 PM

christos accepted this revision.Thu, Jul 2, 3:35 PM

This revision is now accepted and ready to land.Thu, Jul 2, 3:35 PM

Closed by commit rGc1b6ebc2b758: dtrace: Improve DOF section size validation (authored by markj). · Explain WhyMon, Jul 6, 1:28 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc1b6ebc2b758: dtrace: Improve DOF section size validation.

Revision Contents
Changeset List

Path

Size

sys/

cddl/

contrib/

opensolaris/

uts/

common/

dtrace/

dtrace.c

4 lines

Diff 181351

View Options

sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c

dtrace: Improve DOF section size validationClosedPublicActions