Page MenuHomeFreeBSD
Differential D57333

login_class: Fix kqueues, pipebuf resource types
ClosedPublic
Actions

Authored by des on Fri, May 29, 4:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 23, 11:57 AM
Unknown Object (File)
Sat, Jun 20, 3:30 PM
Unknown Object (File)
Sat, Jun 20, 11:30 AM
Unknown Object (File)
Wed, Jun 17, 2:00 AM
Unknown Object (File)
Thu, Jun 11, 3:45 AM
Unknown Object (File)
Sun, Jun 7, 6:38 AM
Unknown Object (File)
Sat, Jun 6, 11:34 PM
Unknown Object (File)
Sat, Jun 6, 5:15 PM
View All 14 Files
Subscribers
andrew_tao173.riddles.org.uk
imp

Details

Reviewers
kib
olce
Commits
rG34fc5ccbc553: login_class: Fix kqueues, pipebuf resource types
rG2a0e9a9b5934: login_class: Fix kqueues, pipebuf resource types
rGb5dce0ae4f78: login_class: Fix kqueues, pipebuf resource types
Summary
  • kqueues is a count but is listed as a size
  • pipebuf is a size but is listed as a count

PR: 295623
MFC after: 1 week
Fixes: a4c04958f526 ("libutil: support RLIMIT_PIPEBUF")
Fixes: 85a0ddfd0b26 ("Add a resource limit for the total...")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Fri, May 29, 4:01 PM
Herald added a reviewer: olce. · View Herald TranscriptFri, May 29, 4:01 PM
Herald added a subscriber: imp. · View Herald Transcript
des requested review of this revision.Fri, May 29, 4:01 PM
Herald added a subscriber: andrew_tao173.riddles.org.uk. · View Herald TranscriptFri, May 29, 4:01 PM
Harbormaster completed remote builds in B73549: Diff 178918.Fri, May 29, 4:02 PM
des added a comment.Fri, May 29, 4:04 PM

Looking at the kernel code, it looks like RLIMIT_PIPEBUF really is a count, not a size. The getrlimit(2) manual page lists it as a size. So I should correct the documentation instead. RLIMIT_KQUEUES is definitely not a size though.

kib accepted this revision.Fri, May 29, 5:41 PM
This revision is now accepted and ready to land.Fri, May 29, 5:41 PM
des added a comment.Fri, May 29, 5:42 PM

@kib is RLIMIT_PIPEBUF meant to be a count or a size?

kib added a comment.Fri, May 29, 5:46 PM
In D57333#1313719, @des wrote:

@kib is RLIMIT_PIPEBUF meant to be a count or a size?

It is size in KVA of the consumed pipe bufs.

Closed by commit rGb5dce0ae4f78: login_class: Fix kqueues, pipebuf resource types (authored by des). · Explain WhyFri, May 29, 10:07 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGb5dce0ae4f78: login_class: Fix kqueues, pipebuf resource types.
des added a commit: rG2a0e9a9b5934: login_class: Fix kqueues, pipebuf resource types.Thu, Jun 4, 2:41 PM
des added a commit: rG34fc5ccbc553: login_class: Fix kqueues, pipebuf resource types.

Revision Contents
Changeset List

PathSize
lib/
libutil/
4 lines

Diff 178954

View Options

lib/libutil/login_class.c

Loading...