Page MenuHomeFreeBSD

bsdinstall.8: note that installerscript variables must be exported
AbandonedPublic

Authored by asomers on May 29 2026, 1:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 18, 8:44 AM
Unknown Object (File)
Thu, Jul 16, 3:10 AM
Unknown Object (File)
Sun, Jul 5, 6:57 AM
Unknown Object (File)
Sun, Jun 28, 3:49 PM
Unknown Object (File)
Sun, Jun 28, 3:48 PM
Unknown Object (File)
Jun 17 2026, 11:22 AM
Unknown Object (File)
Jun 14 2026, 9:35 AM
Unknown Object (File)
Jun 13 2026, 5:43 AM
Subscribers

Details

Reviewers
jlduran
Summary

Reported by: jlduran
MFC after: 1 week

Test Plan

Doc change only

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 73533
Build 70416: arc lint + arc unit

Event Timeline

Hmm, I was about to submit a change that:

--- a/usr.sbin/bsdinstall/scripts/script
+++ b/usr.sbin/bsdinstall/scripts/script
@@ -50,6 +50,7 @@ f_include $BSDCFG_SHARE/variable.subr
 ############################################################ GLOBALS

 : ${TMPDIR:="/tmp"}
+: ${DISTRIBUTIONS=""}; export DISTRIBUTIONS

 #
 # Strings that should be moved to an i18n file and loaded with f_include_lang()

In my opinion is a "better" fix.

Hmm, I was about to submit a change that:

--- a/usr.sbin/bsdinstall/scripts/script
+++ b/usr.sbin/bsdinstall/scripts/script
@@ -50,6 +50,7 @@ f_include $BSDCFG_SHARE/variable.subr
 ############################################################ GLOBALS

 : ${TMPDIR:="/tmp"}
+: ${DISTRIBUTIONS=""}; export DISTRIBUTIONS

 #
 # Strings that should be moved to an i18n file and loaded with f_include_lang()

In my opinion is a "better" fix.

Yeah, I like that too, if it means that the user doesn't need to care.

Also, note that PARTITIONS is not used in any other script, so there is no need to export (there has never been the need to export it either).