Page MenuHomeFreeBSD

Mk/bsd.port.mk: Add EXTRACT_ENV
ClosedPublic

Authored by des on Thu, May 28, 10:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 21, 1:43 PM
Unknown Object (File)
Fri, Jun 12, 2:38 PM
Unknown Object (File)
Wed, Jun 10, 10:49 AM
Unknown Object (File)
Tue, Jun 9, 3:28 AM
Unknown Object (File)
Tue, Jun 9, 3:23 AM
Unknown Object (File)
Sun, Jun 7, 2:00 PM
Unknown Object (File)
Sun, Jun 7, 2:00 PM
Unknown Object (File)
Sat, Jun 6, 7:40 AM
Subscribers

Details

Summary

Add an EXTRACT_ENV variable which defaults to LC_ALL=C.UTF-8. We set
LC_ALL=C globally to ensure our scripts work the way we intend them to,
but this causes tar and unzip to fail to extract distfiles containing
names that cannot be expressed in ASCII. This was previously masked by
a bug in libarchive which caused tar and unzip to fail to notice that
these names were unconvertible and just pass them through unchanged.

MFH: 2026Q2

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Thu, May 28, 10:43 AM
des created this revision.
This revision is now accepted and ready to land.Thu, May 28, 11:17 AM
This revision was automatically updated to reflect the committed changes.
arrowd added inline comments.
Mk/bsd.port.mk
3214

Shouldn't this also have ${SETENV} before ${EXTRACT_ENV}. This is how all other *_ENV knobs are used.

Mk/bsd.port.mk
3214

I can add it for consistency's sake, but it isn't actually needed, and it adds a small amount of overhead.