Page MenuHomeFreeBSD
Differential D57245

divert: Fix handling of the bound state
AbandonedPublic
Actions

Authored by markj on May 26 2026, 1:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 14, 3:03 PM
Unknown Object (File)
Thu, Aug 13, 3:31 PM
Unknown Object (File)
Thu, Aug 13, 3:29 PM
Unknown Object (File)
Thu, Aug 13, 12:08 AM
Unknown Object (File)
Mon, Aug 10, 11:36 AM
Unknown Object (File)
Sat, Aug 8, 5:13 AM
Unknown Object (File)
Mon, Jul 27, 4:04 PM
Unknown Object (File)
Tue, Jul 21, 3:06 PM
View All 20 Files
Subscribers
asomers
imp
melifaro

Details

Reviewers
glebius
Group Reviewers
network
Summary

Commit f1fb05171662 added a field to the divert PCB which indicates
whether the socket is bound. This field is never set however, so
div_detach() doesn't remove a bound socket from the hash before freeing
it.

Fixes: f1fb05171662 ("divert(4): maintain own cb database and stop using inpcb KPI")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73444
Build 70327: arc lint + arc unit

Event Timeline

markj created this revision.May 26 2026, 1:41 PM
Herald added subscribers: melifaro, asomers, imp. · View Herald TranscriptMay 26 2026, 1:41 PM
markj requested review of this revision.May 26 2026, 1:41 PM
Harbormaster completed remote builds in B73444: Diff 178604.May 26 2026, 1:41 PM
markj abandoned this revision.May 26 2026, 1:53 PM

Sorry, never mind, I missed that dcb_bound is set implicitly via the union.

Revision Contents
Changeset List

PathSize
sys/
netinet/
14 lines
tests/
sys/
common/
24 lines
netinet/
22 lines

Diff 178604

View Options

sys/netinet/ip_divert.c

Loading...
View Options

tests/sys/common/divert.py

Loading...
View Options

tests/sys/netinet/divert.sh

Loading...