Differential D57062

bhyve: Check rfb length
Needs ReviewPublic
Actions

Authored by aokblast on Mon, May 18, 7:17 AM.

Tags

None

Referenced Files

	F158964415: D57062.id177997.diff
	Mon, Jun 8, 8:51 AM

	Unknown Object (File)
	Fri, Jun 5, 10:02 AM

	Unknown Object (File)
	Fri, Jun 5, 10:00 AM

	Unknown Object (File)
	Fri, Jun 5, 4:11 AM

	Unknown Object (File)
	Fri, Jun 5, 4:08 AM

	Unknown Object (File)
	Thu, Jun 4, 10:37 PM

	Unknown Object (File)
	Tue, Jun 2, 11:45 PM

	Unknown Object (File)
	Tue, Jun 2, 11:40 PM

View All 19 Files

Subscribers

Details

Reviewers

Group Reviewers

Summary

RFB protocol preallocate the buffer memory based on the maximum width
and height that defined by rfb.c. However, the rfb doesn't know the
width and height information from the caller (pci_fbuf.c). It causes
problem while fbuf allows larger size than rfb. As a result, we add
checks by passing width and height parameters to the rfb_init.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 73215
Build 70098: arc lint + arc unit

Event Timeline

aokblast created this revision.Mon, May 18, 7:17 AM

Herald added a reviewer: bhyve. · View Herald TranscriptMon, May 18, 7:17 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

aokblast requested review of this revision.Mon, May 18, 7:17 AM

Harbormaster completed remote builds in B73182: Diff 177997.Mon, May 18, 7:17 AM

aokblast added a reviewer: markj.Mon, May 18, 7:17 AM

corvink added a subscriber: corvink.Tue, May 19, 6:27 AM

corvink added inline comments.

usr.sbin/bhyve/rfb.c
1356–1361	We're allocating the rfb here, don't we? Why are we still allocating the max rfb size? Why not allocating the requested size?

Remove size limit and relies on the frontend

usr.sbin/bhyve/rfb.c
1356–1361	Makes sense. Fix it now. Thanks!

Harbormaster completed remote builds in B73215: Diff 178068.Tue, May 19, 6:51 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

3 lines

4 lines

30 lines

Diff 178068

usr.sbin/bhyve/pci_fbuf.c

Loading...

usr.sbin/bhyve/rfb.h

Loading...

usr.sbin/bhyve/rfb.c

Loading...