libufs: Avoid using param.h constants in libufs.h
ClosedPublic
Actions

Authored by markj on Wed, May 6, 7:25 PM.

Details

Reviewers

mckusick
kib

Commits

rG8e44312642d2: libufs: Avoid using param.h constants in libufs.h
rG271d25a066b5: libufs: Avoid using param.h constants in libufs.h

Summary

MAXBSIZE is defined in param.h, which defines many other things. To
avoid forcing all consumers of libufs.h to include param.h, let's
instead redefine it and verify the definition in inode.c.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Wed, May 6, 7:25 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, May 6, 7:25 PM

markj requested review of this revision.Wed, May 6, 7:25 PM

Harbormaster completed remote builds in B72862: Diff 177326.Wed, May 6, 7:25 PM

markj added a parent revision: D56858: fsck_ffs: Avoid relying on param.h pollution from libufs.h.Wed, May 6, 7:25 PM

kib accepted this revision.Wed, May 6, 7:35 PM

This revision is now accepted and ready to land.Wed, May 6, 7:35 PM

Closed by commit rG271d25a066b5: libufs: Avoid using param.h constants in libufs.h (authored by markj). · Explain WhyTue, May 12, 8:06 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG271d25a066b5: libufs: Avoid using param.h constants in libufs.h.

markj added a commit: rG8e44312642d2: libufs: Avoid using param.h constants in libufs.h.Tue, May 19, 2:09 PM

Revision Contents
Changeset List

Path

Size

lib/

libufs/

inode.c

3 lines

libufs.h

7 lines

Diff 177709

View Options

lib/libufs/inode.c