fsck_ffs: Avoid relying on param.h pollution from libufs.h
ClosedPublic
Actions

Authored by markj on May 6 2026, 7:25 PM.

Details

Reviewers

mckusick
kib

Commits

rGe2053ee82d2c: fsck_ffs: Avoid relying on param.h pollution from libufs.h
rG3cd3900b690d: fsck_ffs: Avoid relying on param.h pollution from libufs.h

Summary

gjournal.c needs param.h to get a definition of isclr().
fsck.h needs signal.h for sig_atomic_t.

Sort includes while here.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 6 2026, 7:25 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 6 2026, 7:25 PM

markj requested review of this revision.May 6 2026, 7:25 PM

Harbormaster completed remote builds in B72861: Diff 177325.May 6 2026, 7:25 PM

markj added a child revision: D56859: libufs: Avoid using param.h constants in libufs.h.May 6 2026, 7:25 PM

kib accepted this revision.May 6 2026, 7:33 PM

This revision is now accepted and ready to land.May 6 2026, 7:33 PM

Closed by commit rG3cd3900b690d: fsck_ffs: Avoid relying on param.h pollution from libufs.h (authored by markj). · Explain WhyMay 12 2026, 8:06 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG3cd3900b690d: fsck_ffs: Avoid relying on param.h pollution from libufs.h.

markj added a commit: rGe2053ee82d2c: fsck_ffs: Avoid relying on param.h pollution from libufs.h.May 19 2026, 2:09 PM

Revision Contents
Changeset List

Path

Size

sbin/

fsck_ffs/

fsck.h

9 lines

gjournal.c

4 lines

Diff 177708

View Options

sbin/fsck_ffs/fsck.h