Page MenuHomeFreeBSD
Differential D56628

ctl_ioctl_frontend: Reject out-of-range initiator IDs
AcceptedPublic
Actions

Authored by jhb on Fri, Apr 24, 8:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 29, 3:28 AM
Unknown Object (File)
Tue, Apr 28, 7:45 AM
Unknown Object (File)
Mon, Apr 27, 10:12 AM
Unknown Object (File)
Sun, Apr 26, 7:58 AM
Subscribers
imp

Details

Reviewers
asomers
mav
ken
Group Reviewers
cam
Summary

Various places in CTL assume that initiator IDs are not larger than
CTL_MAX_INIT_PER_PORT. Other IDs such as lun IDs are validated in
places such as ctl_scsiio_precheck, but initiator IDs submitted by
userland were not previously validated.

PR: 291059
Reported by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72532
Build 69415: arc lint + arc unit

Event Timeline

jhb created this revision.Fri, Apr 24, 8:35 PM
Herald added a reviewer: cam. · View Herald TranscriptFri, Apr 24, 8:35 PM
Herald added a subscriber: imp. · View Herald Transcript
jhb requested review of this revision.Fri, Apr 24, 8:35 PM
Harbormaster completed remote builds in B72532: Diff 176430.Fri, Apr 24, 8:35 PM
asomers accepted this revision.Fri, Apr 24, 8:53 PM

Good catch. Is this something that can be triggered with libcam?

This revision is now accepted and ready to land.Fri, Apr 24, 8:53 PM

Revision Contents
Changeset List

PathSize
sys/
cam/
ctl/
11 lines

Diff 176430

View Options

sys/cam/ctl/ctl_frontend_ioctl.c

Loading...