ctld: Simplify pidfile rename handling in conf::apply
ClosedPublic
Actions

Authored by jhb on Apr 20 2026, 4:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jun 5, 12:04 AM

	Unknown Object (File)
	Thu, May 14, 2:33 AM

	Unknown Object (File)
	Wed, May 13, 7:50 PM

	Unknown Object (File)
	Mon, May 11, 9:43 PM

	Unknown Object (File)
	Mon, May 11, 2:51 PM

	Unknown Object (File)
	May 5 2026, 9:04 AM

	Unknown Object (File)
	May 3 2026, 8:54 PM

	Unknown Object (File)
	May 3 2026, 8:50 PM

View All 16 Files

Subscribers

imp

Details

Reviewers

asomers
kevans

Commits

rG9306d0449ba6: ctld: Simplify pidfile rename handling in conf::apply

Summary

Explicitly copy the pidfile path from the initial configuration file
to the kernel-derived configuration to avoid having to check if the
old path is empty as a special case in conf::apply().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 20 2026, 4:57 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 20 2026, 4:57 PM

jhb requested review of this revision.Apr 20 2026, 4:57 PM

Harbormaster completed remote builds in B72377: Diff 175920.Apr 20 2026, 4:57 PM

jhb added a parent revision: D56532: ctld: Add a dedicated conf method for shutting down.Apr 20 2026, 4:57 PM

jhb added a reviewer: kevans.Apr 24 2026, 2:17 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 18, 7:51 PM

Closed by commit rG9306d0449ba6: ctld: Simplify pidfile rename handling in conf::apply (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG9306d0449ba6: ctld: Simplify pidfile rename handling in conf::apply.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

ctld.cc

25 lines

Diff 178033

View Options

ctld: Simplify pidfile rename handling in conf::applyClosedPublicActions