Differential D56525

ctld: Return from the inner "main" loop on EINTR
ClosedPublic
Actions

Authored by jhb on Apr 20 2026, 2:26 PM.

Tags

None

Referenced Files

	F160691751: D56525.id175901.diff
	Fri, Jun 26, 8:38 PM

	Unknown Object (File)
	Tue, Jun 23, 3:17 PM

	Unknown Object (File)
	Thu, Jun 4, 2:20 PM

	Unknown Object (File)
	Thu, May 28, 2:17 PM

	Unknown Object (File)
	May 15 2026, 1:41 PM

	Unknown Object (File)
	May 15 2026, 1:27 PM

	Unknown Object (File)
	May 15 2026, 3:42 AM

	Unknown Object (File)
	May 12 2026, 2:32 PM

View All 35 Files

Subscribers

Details

Reviewers

Commits

rG0efab2ba4c00: ctld: Return from the inner "main" loop on EINTR
rGe56687bb2d32: ctld: Return from the inner "main" loop on EINTR

Summary

This ensures that child processes are reaped in the outer loop in
main().

PR: 294035
Fixes: 66b107e82b2f ("ctld: Use kevent(2) for socket events rather than select(2)")
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 20 2026, 2:26 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 20 2026, 2:26 PM

Harbormaster completed remote builds in B72366: Diff 175901.Apr 20 2026, 2:26 PM

jhb requested review of this revision.Apr 20 2026, 2:26 PM

jhb added a child revision: D56526: ctld: Update nchildren directly in wait_for_children.

asomers accepted this revision.Apr 20 2026, 4:22 PM

This revision is now accepted and ready to land.Apr 20 2026, 4:22 PM

Closed by commit rGe56687bb2d32: ctld: Return from the inner "main" loop on EINTR (authored by Nikolay Denev <ndenev@gmail.com>, committed by jhb). · Explain WhyApr 20 2026, 5:20 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe56687bb2d32: ctld: Return from the inner "main" loop on EINTR.

jhb added a commit: rG0efab2ba4c00: ctld: Return from the inner "main" loop on EINTR.Tue, Jun 23, 4:30 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

2 lines

Diff 175924

usr.sbin/ctld/ctld.cc

Loading...