ctld: Return from the inner "main" loop on EINTR
ClosedPublic
Actions

Authored by jhb on Mon, Apr 20, 2:26 PM.

Tags

None

Referenced Files

	F156669055: D56525.id175901.diff
	Fri, May 15, 1:41 PM

	F156667732: D56525.id175924.diff
	Fri, May 15, 1:27 PM

	F156616162: D56525.id.diff
	Fri, May 15, 3:42 AM

	Unknown Object (File)
	Tue, May 12, 2:32 PM

	Unknown Object (File)
	Mon, May 11, 6:25 AM

	Unknown Object (File)
	Sun, May 10, 8:09 AM

	Unknown Object (File)
	Sun, May 10, 8:05 AM

	Unknown Object (File)
	Sun, May 10, 2:37 AM

View All 31 Files

Subscribers

imp

Details

Reviewers

asomers

Commits

rGe56687bb2d32: ctld: Return from the inner "main" loop on EINTR

Summary

This ensures that child processes are reaped in the outer loop in
main().

PR: 294035
Fixes: 66b107e82b2f ("ctld: Use kevent(2) for socket events rather than select(2)")
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mon, Apr 20, 2:26 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Apr 20, 2:26 PM

Harbormaster completed remote builds in B72366: Diff 175901.Mon, Apr 20, 2:26 PM

jhb requested review of this revision.Mon, Apr 20, 2:26 PM

jhb added a child revision: D56526: ctld: Update nchildren directly in wait_for_children.

asomers accepted this revision.Mon, Apr 20, 4:22 PM

This revision is now accepted and ready to land.Mon, Apr 20, 4:22 PM

Closed by commit rGe56687bb2d32: ctld: Return from the inner "main" loop on EINTR (authored by Nikolay Denev <ndenev@gmail.com>, committed by jhb). · Explain WhyMon, Apr 20, 5:20 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe56687bb2d32: ctld: Return from the inner "main" loop on EINTR.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

ctld.cc

2 lines

Diff 175924

View Options

ctld: Return from the inner "main" loop on EINTRClosedPublicActions