Differential D56524

ctld: Ports without a portal group are not dummy ports
ClosedPublic
Actions

Authored by jhb on Apr 20 2026, 2:18 PM.

Details

Reviewers

asomers

Commits

rG3df5cc33d894: ctld: Ports without a portal group are not dummy ports

Summary

The default implementation of is_dummy needs to return false. Only
portal group ports should possibly return true.

PR: 293076
Reported by: Ken J. Thomson <thomsonk@yandex.com>
Fixes: 6acc7afa34aa ("ctld: Convert struct port to a hierarchy of C++ classes")
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Apr 20 2026, 2:18 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 20 2026, 2:18 PM

jhb requested review of this revision.Apr 20 2026, 2:18 PM

Harbormaster completed remote builds in B72363: Diff 175898.Apr 20 2026, 2:18 PM

jhb added a parent revision: D56523: ctld: Don't add an iscsi port for targets with only kernel ports.Apr 20 2026, 2:19 PM

jhb mentioned this in D56541: ctld: convert an EEXIST in kernel port creation to an update request.Apr 23 2026, 4:32 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 23 2026, 7:18 PM

Closed by commit rG3df5cc33d894: ctld: Ports without a portal group are not dummy ports (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG3df5cc33d894: ctld: Ports without a portal group are not dummy ports.

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

ctld.hh

2 lines

Diff 176286

View Options

ctld: Ports without a portal group are not dummy portsClosedPublicActions