acpi_spmc(4): Small probe improvements/fixes
ClosedPublic
Actions

Authored by olce on Fri, Apr 17, 7:52 PM.

Details

Reviewers

Commits

rG0a764beb6215: acpi_spmc(4): Remove redundant setting of 'sc->dev' on attach
rGbd05b47fbd8b: acpi_spmc(4): Small probe improvements/fixes

Summary

Remove the test on presence of an ACPI handle, this is implied by
ACPI_ID_PROBE() succeeding.

Set 'sc->dev' early, so that acpi_spmc_check_dsm_set() using
device_printf() will print the driver name.

Add a missing newline after printing that more DSM functions are
implemented then expected.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Fri, Apr 17, 7:52 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 17, 7:52 PM

olce requested review of this revision.Fri, Apr 17, 7:52 PM

Harbormaster completed remote builds in B72303: Diff 175785.Fri, Apr 17, 7:53 PM

obiwac accepted this revision.Fri, Apr 17, 8:03 PM

obiwac added inline comments.

sys/dev/acpica/acpi_spmc.c
207	if we do this here then no point in doing it again in attach right?

This revision is now accepted and ready to land.Fri, Apr 17, 8:03 PM

olce added inline comments.Fri, Apr 17, 8:12 PM

sys/dev/acpica/acpi_spmc.c
207	Sure (because we return 0). I'll remove it there.

olce marked an inline comment as done.Fri, Apr 17, 8:25 PM

Closed by commit rGbd05b47fbd8b: acpi_spmc(4): Small probe improvements/fixes (authored by olce). · Explain WhyFri, Apr 17, 8:28 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGbd05b47fbd8b: acpi_spmc(4): Small probe improvements/fixes.

olce added a commit: rG0a764beb6215: acpi_spmc(4): Remove redundant setting of 'sc->dev' on attach.Fri, Apr 17, 9:05 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi_spmc.c

9 lines

Diff 175788

View Options

sys/dev/acpica/acpi_spmc.c

acpi_spmc(4): Small probe improvements/fixesClosedPublicActions