tunefs: Fix pointer arithmetic
ClosedPublic
Actions

Authored by des on Fri, Apr 10, 3:15 PM.

Details

Reviewers

ivy
kevans
mckusick

Commits

rG9d95d806691e: tunefs: Fix pointer arithmetic

Summary

While here, remove a bogus const which has been there for years.

MFC after: 1 week
Reported by: ivy@
Fixes: 1b83e8a3f840 ("Constify string pointers.")
Fixes: 8244dd326265 ("tunefs: Better fix for arm64 alignment issues")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Fri, Apr 10, 3:15 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 10, 3:15 PM

des requested review of this revision.Fri, Apr 10, 3:15 PM

Harbormaster completed remote builds in B72110: Diff 175234.Fri, Apr 10, 3:15 PM

Harbormaster completed remote builds in B72111: Diff 175235.Fri, Apr 10, 3:28 PM

olce added a subscriber: olce.Fri, Apr 10, 3:50 PM

olce added inline comments.

sbin/tunefs/tunefs.c
717	Could you please remove as well the `(uintptr_t)` conversion that I suspect was here just to circumvent the bogus `const` in the signature?

des marked an inline comment as done.Fri, Apr 10, 3:52 PM

des added inline comments.

sbin/tunefs/tunefs.c
717	No, it was added last week to suppress an alignment warning and is still needed.

des mentioned this in D56245: tunefs: Better fix for arm64 alignment issues.Fri, Apr 10, 3:56 PM

des marked an inline comment as done.Fri, Apr 10, 4:06 PM

Whoops-

This revision is now accepted and ready to land.Sat, Apr 11, 4:41 PM

Closed by commit rG9d95d806691e: tunefs: Fix pointer arithmetic (authored by des). · Explain WhySat, Apr 11, 7:23 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG9d95d806691e: tunefs: Fix pointer arithmetic.

Revision Contents
Changeset List

Path

Size

sbin/

tunefs/

tunefs.c

4 lines

Diff 175297

View Options

tunefs: Fix pointer arithmeticClosedPublicActions