kvm: introduce kvm_minidump_to_elf()
Needs ReviewPublic
Actions

Authored by minsoochoo0122_proton.me on Sat, Apr 4, 2:59 AM.

Details

Reviewers

None

Group Reviewers

Contributor Reviews (src)

Summary

Since debugging kernel dumps requires libkvm, cross-debugging them is
almost impossible. This function converts minidump to elf core format so
they can be debugged on any platforms where debuggers support elf core
format.

Signed-off-by: Minsoo Choo <minsoochoo0122@proton.me>
Sponsored by: The FreeBSD Foundation
Co-authored-by: Bora Ozarslan <borako.ozarslan@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 71958
Build 68841: arc lint + arc unit

Event Timeline

minsoochoo0122_proton.me created this revision.Sat, Apr 4, 2:59 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptSat, Apr 4, 2:59 AM

minsoochoo0122_proton.me requested review of this revision.Sat, Apr 4, 2:59 AM

Harbormaster completed remote builds in B71957: Diff 174900.Sat, Apr 4, 2:59 AM

This is improvement for D19253, but I moved this to libkvm so utilities like savecore(8) can invoke this easily.

Should I open this to fulldump as well and thus rename it to kvm_convert_to_elf()?

The reason I'm asking this is because I'm planning to copy .gnu_build_id from kernel to elf core so debuggers can reject it if UUID doesn't match. I can implement it for fulldump while kernel is dumping, but it seems redundant to implement it again in libkvm for minidump.

lib/libkvm/kvm_minidump_to_elf.3
20	Is there a better name for `apply_kerndisp`?
138	what is a good macro for `libkvm`? Also should "improvements" be singular or plural? (I'm not good at English grammar and not sure if improvement can be plural in formal writing)