diff3: set O_CLOEXEC on pipes
ClosedPublic
Actions

Authored by bapt on Sat, Mar 28, 8:42 AM.

Tags

None

Referenced Files

	F153939280: D56120.id.diff
	Fri, Apr 24, 11:11 PM

	Unknown Object (File)
	Tue, Apr 21, 12:21 PM

	Unknown Object (File)
	Mon, Apr 20, 8:58 AM

	Unknown Object (File)
	Sun, Apr 19, 12:19 AM

	Unknown Object (File)
	Sat, Apr 18, 10:09 PM

	Unknown Object (File)
	Sat, Apr 18, 9:52 PM

	Unknown Object (File)
	Fri, Apr 17, 10:12 AM

	Unknown Object (File)
	Fri, Apr 17, 9:48 AM

View All 19 Files

Subscribers

imp

Details

Reviewers

kib

Commits

rG8fade076dd25: diff3: set O_CLOEXEC on pipes
rG945e60e018c2: diff3: set O_CLOEXEC on pipes

Summary

This avoid leaking pipe fd in children and simplifies the code

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt created this revision.Sat, Mar 28, 8:42 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Mar 28, 8:42 AM

bapt requested review of this revision.Sat, Mar 28, 8:42 AM

Harbormaster completed remote builds in B71761: Diff 174424.Sat, Mar 28, 8:42 AM

bapt added a reviewer: kib.Sat, Mar 28, 8:43 AM

kib accepted this revision.Sat, Mar 28, 8:48 AM

This revision is now accepted and ready to land.Sat, Mar 28, 8:48 AM

Closed by commit rG945e60e018c2: diff3: set O_CLOEXEC on pipes (authored by bapt). · Explain WhySat, Mar 28, 8:56 AM

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rG945e60e018c2: diff3: set O_CLOEXEC on pipes.

bapt added a commit: rG8fade076dd25: diff3: set O_CLOEXEC on pipes.Mon, Apr 6, 4:52 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

diff3/

diff3.c

8 lines

Diff 174427

View Options

diff3: set O_CLOEXEC on pipesClosedPublicActions