newsyslog: check for rename failure during log rotation

[chris.longros_gmail.com]

Summary

Add a missing error check on rename(2) when shifting compressed
log files. On failure, warn and skip the affected file.

Signed-off-by: Christos Longros <[e-mail]>

[imp]

warn wouldn't seem to be ideal to me, but it matches how everything else is reported for 'routine' or 'expected' errors.

[glebius]

usr.sbin/newsyslog/newsyslog.c

1958–1960

That will more stylish.

[chris.longros_gmail.com]

usr.sbin/newsyslog/newsyslog.c

1958–1960

Do you maybe mean

else if (rename(zfile1, zfile2) != 0)

?

[glebius]

usr.sbin/newsyslog/newsyslog.c

1958–1960

Yes, of course, sorry for that.

[chris.longros_gmail.com]

Use explicit != 0 check.

[chris.longros_gmail.com]

This comment was removed by chris.longros_gmail.com.

usr.sbin/newsyslog/newsyslog.c

1958–1960

Done !