Page MenuHomeFreeBSD

Do not include system call wrappers in libc for old FreeBSD system calls.
ClosedPublic

Authored by jhb on Mar 9 2016, 7:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 7:10 PM
Unknown Object (File)
Thu, Dec 5, 8:00 AM
Unknown Object (File)
Nov 23 2024, 12:58 PM
Unknown Object (File)
Oct 9 2024, 7:56 PM
Unknown Object (File)
Oct 2 2024, 3:13 AM
Unknown Object (File)
Oct 1 2024, 4:45 AM
Unknown Object (File)
Sep 17 2024, 3:05 PM
Unknown Object (File)
Sep 15 2024, 6:02 PM
Subscribers

Details

Summary

Do not include system call wrappers in libc for old FreeBSD system calls.

The base system libc is only used to run binaries built on FreeBSD 7.0 and
later. It does not need to include system call wrappers for system calls
only used by FreeBSD binaries built on versions older than 7.0. This was
already true for "COMPAT" system calls, but now wrappers for system calls
used on FreeBSD 4 and 6 are excluded as well.

Test Plan
  • Still need to do a tinderbox build.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2838
Build 2862: arc lint + arc unit

Event Timeline

jhb retitled this revision from to Do not include system call wrappers in libc for old FreeBSD system calls..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: kib.
kib edited edge metadata.

From what I see, the compat{,4,6} syscalls were not exported from libc. Am I right ?

I am fine with the patch, assuming that the generated files would be regenerated in separate commit.

This revision is now accepted and ready to land.Mar 10 2016, 9:58 AM
In D5597#119463, @kib wrote:

From what I see, the compat{,4,6} syscalls were not exported from libc. Am I right ?

I am fine with the patch, assuming that the generated files would be regenerated in separate commit.

They were not exported from libc.so. They do show up as valid symbols in libc.a, but all symbols do.

This revision was automatically updated to reflect the committed changes.