Paths

Table of Contentst

Differential D5629

fix ppc build without COMPAT_FREEBSD6
AbandonedPublic
Actions

Authored by emaste on Mar 14 2016, 1:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 15, 5:37 AM

	Unknown Object (File)
	Apr 24 2024, 2:26 AM

	Unknown Object (File)
	Mar 14 2024, 1:43 PM

	Unknown Object (File)
	Dec 20 2023, 12:47 AM

	Unknown Object (File)
	Sep 15 2023, 11:59 AM

	Unknown Object (File)
	Sep 7 2023, 9:03 AM

	Unknown Object (File)
	Aug 28 2023, 2:22 AM

	Unknown Object (File)
	Aug 8 2023, 12:22 PM

View All 34 Files

Subscribers

Details

Reviewers

jhibbits
jhb

Summary

Use SYS_freebsd6_lseek only if COMPAT_FREEBSD6 is enabled.

Tinderbox had failed with

/scratch/tmp/emaste/freebsd/sys/powerpc/powerpc/exec_machdep.c: In function 'cpu_set_syscall_retval':
/scratch/tmp/emaste/freebsd/sys/powerpc/powerpc/exec_machdep.c:882: error: 'SYS_freebsd6_lseek' undeclared (first use in this function)
/scratch/tmp/emaste/freebsd/sys/powerpc/powerpc/exec_machdep.c:882: error: (Each undeclared identifier is reported only once
/scratch/tmp/emaste/freebsd/sys/powerpc/powerpc/exec_machdep.c:882: error: for each function it appears in.)
*** [exec_machdep.o] Error code 1

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 14302.Mar 14 2016, 1:38 AM

emaste retitled this revision from to fix ppc build without COMPAT_FREEBSD6.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: jhibbits.

Herald edited edge metadata. · View Herald TranscriptMar 14 2016, 1:38 AM

jhibbits added inline comments.Mar 14 2016, 2:47 AM

sys/powerpc/powerpc/exec_machdep.c
882–889	It looks like you're reversing the check.

Correct sense of test

Herald edited edge metadata. · View Herald TranscriptMar 14 2016, 2:53 AM

jhibbits accepted this revision.Mar 14 2016, 2:57 AM

jhibbits edited edge metadata.

This revision is now accepted and ready to land.Mar 14 2016, 2:57 AM

Adding @jhb as it seems this is fallout from D5597

@bz committed a similar change in rS296861

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

powerpc/

10 lines

Diff 14303

sys/powerpc/powerpc/exec_machdep.c

Loading...