Page MenuHomeFreeBSD
Differential D55836

contrib/zstd: further narrow FREEBSD-Xlist
ClosedPublic
Actions

Authored by siva on Thu, Mar 12, 10:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 9, 4:41 AM
Unknown Object (File)
Wed, Apr 8, 9:54 AM
Unknown Object (File)
Sun, Apr 5, 1:18 PM
Unknown Object (File)
Sun, Apr 5, 11:01 AM
Unknown Object (File)
Wed, Mar 25, 12:54 AM
Unknown Object (File)
Fri, Mar 20, 9:21 PM
Unknown Object (File)
Thu, Mar 19, 5:26 PM
Unknown Object (File)
Thu, Mar 19, 12:40 PM
View All 10 Files
Subscribers
imp

Details

Reviewers
allanjude
emaste
minsoochoo0122_proton.me
Commits
rG7c9418613a31: sys/contrib/zstd: further narrow FREEBSD-Xlist
Summary

We don't need any docs or examples in tree, as well
as any upstream-specific build infrastructure.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

siva created this revision.Thu, Mar 12, 10:45 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Mar 12, 10:45 PM
siva requested review of this revision.Thu, Mar 12, 10:45 PM
Harbormaster completed remote builds in B71375: Diff 173634.Thu, Mar 12, 10:45 PM
siva added a parent revision: D55835: tarfs: swap deprecated ZSTD_resetDStream() with ZSTD_DCtx_reset().Thu, Mar 12, 10:45 PM
siva added a child revision: D55837: Import zstd 1.5.7.
minsoochoo0122_proton.me requested changes to this revision.Fri, Mar 13, 4:11 PM
minsoochoo0122_proton.me added inline comments.
sys/contrib/zstd/FREEBSD-Xlist
1–3

Please update files and folders starting with .. E.g. from https://github.com/facebook/zstd/tree/v1.5.7, I see

.travis.yml and .circleci are gone while .buckconfig and .buckversion are added.

19

I suggest removing README.md and TESTING.md. Keep SECURITY.md so people can report security issues upstream.

Do we need zlibWrapper?

Also it would be nice to do cleanup for files hiding under subdirectories. e.g. lib/*.mk, lib/Makefile, lib/BUCK, etc.

This revision now requires changes to proceed.Fri, Mar 13, 4:11 PM
minsoochoo0122_proton.me added inline comments.Fri, Mar 13, 4:13 PM
sys/contrib/zstd/FREEBSD-Xlist
19

From what is see from D55837 and D55838, these are recursive so all files named BUCK are removed. Am I right?

This revision was not accepted when it landed; it landed in state Needs Revision.Thu, Apr 9, 6:14 AM
Closed by commit rG7c9418613a31: sys/contrib/zstd: further narrow FREEBSD-Xlist (authored by siva, committed by delphij). · Explain Why
This revision was automatically updated to reflect the committed changes.
delphij added a commit: rG7c9418613a31: sys/contrib/zstd: further narrow FREEBSD-Xlist.

Revision Contents
Changeset List

PathSize
sys/
contrib/
zstd/
11 lines

Diff 175172

View Options

sys/contrib/zstd/FREEBSD-Xlist

Loading...