Page MenuHomeFreeBSD

sigreturn.2: refresh the man page
ClosedPublic

Authored by kib on Sun, Mar 8, 8:11 PM.
Tags
None
Referenced Files
F148183801: D55750.id173486.diff
Mon, Mar 16, 8:14 AM
Unknown Object (File)
Sun, Mar 15, 9:55 AM
Unknown Object (File)
Fri, Mar 13, 9:24 PM
Unknown Object (File)
Fri, Mar 13, 9:24 PM
Unknown Object (File)
Fri, Mar 13, 9:24 PM
Unknown Object (File)
Fri, Mar 13, 9:24 PM
Unknown Object (File)
Fri, Mar 13, 12:42 AM
Unknown Object (File)
Wed, Mar 11, 2:57 AM
Subscribers

Details

Summary
Remove mention of the longjmp(3), which does not use sigreturn.
Try to be more precise when describing the syscall effects.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Sun, Mar 8, 8:11 PM

A couple of grammar edits which I hope are correct and clarify things

lib/libsys/sigreturn.2
58
63
63

It seemed to imply -1 may or may not be returned, but errno will always be set.

I hope this edit suggests that if -1 is returned errno holds the error.

65–68
66–68
kib marked 2 inline comments as done.Mon, Mar 9, 6:27 AM
kib added inline comments.
lib/libsys/sigreturn.2
65–68

Could you please provide the complete sentence? Right now it seems that suggested editing result in

Otherwise, a value of -1 may be returned
.Va errno
set to indicate the error.

which does not read correct to me.

lib/libsys/sigreturn.2
65–68

Ah sorry. I was thinking of something like "a value of -1 may be returned, with errno set to indicate the error."

kib marked 4 inline comments as done.

Apply the last suggestion.

lib/libsys/sigreturn.2
52

or maybe userspace

58

The sentence structure is clearer without the comma IMO.

59
kib marked 3 inline comments as done.

Editing by Mark.

markj added inline comments.
lib/libsys/sigreturn.2
52
This revision is now accepted and ready to land.Wed, Mar 11, 1:56 AM
kib marked an inline comment as done.

hyphen

This revision now requires review to proceed.Wed, Mar 11, 5:44 AM
This revision is now accepted and ready to land.Wed, Mar 11, 1:10 PM
This revision was automatically updated to reflect the committed changes.