Differential D5560

Fix reporting of the CloudABI ABI in kdump.
ClosedPublic
Actions

Authored by jhb on Mar 5 2016, 9:00 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 25, 8:58 PM

	Unknown Object (File)
	Sun, Nov 24, 1:48 PM

	Unknown Object (File)
	Nov 16 2024, 5:32 AM

	Unknown Object (File)
	Oct 5 2024, 8:48 AM

	Unknown Object (File)
	Oct 2 2024, 11:54 PM

	Unknown Object (File)
	Sep 25 2024, 4:41 PM

	Unknown Object (File)
	Sep 25 2024, 3:06 AM

	Unknown Object (File)
	Sep 24 2024, 7:37 PM

View All 87 Files

Subscribers

Details

Reviewers

kib
ed

Commits

rS296570: Fix reporting of the CloudABI ABI in kdump.

Summary

Fix reporting of the CloudABI ABI in kdump.

Advertise the word size for CloudABI ABIs via the SV_LP64 flag. All of the other ABIs include either SV_ILP32 or SV_LP64.
Fix kdump to not assume a 32-bit ABI if the ABI flags field is non-zero but SV_LP64 isn't set. Instead, only assume a 32-bit ABI if SV_ILP32 is set and fallback to the unknown value of "00" if neither SV_LP64 or SV_ILP32 is set.

Test Plan

ktrace a CloudABI program and run kdump on the trace

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 14107.Mar 5 2016, 9:00 PM

jhb retitled this revision from to Fix reporting of the CloudABI ABI in kdump..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added reviewers: kib, ed.

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptMar 5 2016, 9:00 PM

kib accepted this revision.Mar 5 2016, 9:26 PM

kib edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2016, 9:26 PM

ed accepted this revision.Mar 6 2016, 12:42 AM

ed edited edge metadata.

Closed by commit rS296570: Fix reporting of the CloudABI ABI in kdump. (authored by jhb). · Explain WhyMar 9 2016, 6:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

cloudabi64/

cloudabi64_sysvec.c

2 lines

arm64/

cloudabi64/

cloudabi64_sysvec.c

2 lines

usr.bin/

kdump/

11 lines

Diff 14194

head/sys/amd64/cloudabi64/cloudabi64_sysvec.c

Loading...

head/sys/arm64/cloudabi64/cloudabi64_sysvec.c

Loading...

head/usr.bin/kdump/kdump.c

Loading...