Page MenuHomeFreeBSD
Differential D55394

asmc: code style modernization and minor cleanups
ClosedPublic
Actions

Authored by ngie on Fri, Feb 20, 3:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 21, 12:18 AM
Unknown Object (File)
Fri, Mar 20, 1:36 AM
Unknown Object (File)
Fri, Mar 13, 8:52 PM
Unknown Object (File)
Thu, Mar 12, 3:28 PM
Unknown Object (File)
Thu, Mar 12, 7:34 AM
Unknown Object (File)
Tue, Mar 10, 11:04 AM
Unknown Object (File)
Mon, Mar 9, 6:50 PM
Unknown Object (File)
Sun, Mar 8, 5:28 PM
View All 21 Files
Subscribers
imp

Details

Reviewers
markj
adrian
guest-seuros
Commits
rGe20e26e4e271: asmc: code style modernization and minor cleanups
Summary
  • Allow ASMC_DEBUG to be treated as a variadic macro.
  • Add ellipses around sizeof(..) calls.
  • Reindent some of the lines to better follow style(9) with line wrapping.

A number of other clang-format changes were not taken as they are not
compatible with style(9). A change to the config to improve
compatibility with style(9) is pending.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ngie created this revision.Fri, Feb 20, 3:55 AM
Herald added a subscriber: imp. · View Herald TranscriptFri, Feb 20, 3:55 AM
ngie requested review of this revision.Fri, Feb 20, 3:55 AM
Harbormaster completed remote builds in B70812: Diff 172298.Fri, Feb 20, 3:55 AM
ngie added reviewers: markj, adrian, guest-seuros.Fri, Feb 20, 6:03 AM
guest-seuros accepted this revision.Fri, Feb 20, 5:55 PM
This revision is now accepted and ready to land.Fri, Feb 20, 5:55 PM
ngie updated this revision to Diff 172353.Sat, Feb 21, 12:12 AM

Fix compilation errors.

vimdiff... you're such a PITA sometimes...

This revision now requires review to proceed.Sat, Feb 21, 12:12 AM
Harbormaster completed remote builds in B70843: Diff 172353.Sat, Feb 21, 12:13 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sat, Feb 21, 5:32 AM
Closed by commit rGe20e26e4e271: asmc: code style modernization and minor cleanups (authored by ngie). · Explain Why
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rGe20e26e4e271: asmc: code style modernization and minor cleanups.

Revision Contents
Changeset List

PathSize
sys/
dev/
asmc/
106 lines

Diff 172360

View Options

sys/dev/asmc/asmc.c

Loading...