Page MenuHomeFreeBSD
Differential D55293

libfetch: Restore timeout functionality
ClosedPublic
Actions

Authored by des on Mon, Feb 16, 2:30 AM.
Tags
None
Referenced Files
F146223832: D55293.id.diff
Sat, Feb 28, 9:47 PM
Unknown Object (File)
Tue, Feb 24, 9:57 PM
Unknown Object (File)
Mon, Feb 23, 8:45 AM
Unknown Object (File)
Sat, Feb 21, 1:47 AM
Unknown Object (File)
Thu, Feb 19, 11:39 PM
Unknown Object (File)
Wed, Feb 18, 12:59 PM
Unknown Object (File)
Wed, Feb 18, 11:51 AM
Unknown Object (File)
Tue, Feb 17, 3:03 AM
View All 10 Files
Subscribers
imp
marck

Details

Reviewers
imp
eugen_grosbein.net
Commits
rG8755b5f3a590: libfetch: Restore timeout functionality
rG589cef5d5151: libfetch: Restore timeout functionality
rGd97c824f5b4c: libfetch: Restore timeout functionality
rGae12f0f08e02: libfetch: Restore timeout functionality
rG73b82d1b0a2f: libfetch: Restore timeout functionality
Summary

PR: 293124
MFC after: 1 week
Fixes: 792ef1ae7b94 ("Refactor fetch_connect() and fetch_bind() to improve readability and avoid repeating the same DNS lookups.")
Reverts: 8f8a7f6fffd7 ("libfetch: apply timeout to SSL_read()")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Mon, Feb 16, 2:30 AM
Herald added a subscriber: imp. · View Herald TranscriptMon, Feb 16, 2:30 AM
des requested review of this revision.Mon, Feb 16, 2:30 AM
Harbormaster completed remote builds in B70682: Diff 171944.Mon, Feb 16, 2:30 AM
imp accepted this revision.Mon, Feb 16, 2:39 AM

This looks right to me

This revision is now accepted and ready to land.Mon, Feb 16, 2:39 AM
des added a reviewer: eugen_grosbein.net.Wed, Feb 18, 12:35 AM
marck added a subscriber: marck.Wed, Feb 18, 12:17 PM
eugen_grosbein.net accepted this revision.Wed, Feb 18, 1:18 PM

I got a confirmation from one of local FreeBSD users that this change works just fine. Thanks!

Closed by commit rG73b82d1b0a2f: libfetch: Restore timeout functionality (authored by des). · Explain WhyWed, Feb 18, 3:11 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG73b82d1b0a2f: libfetch: Restore timeout functionality.
des added a commit: rGae12f0f08e02: libfetch: Restore timeout functionality.Wed, Feb 18, 6:39 PM
des added a commit: rGd97c824f5b4c: libfetch: Restore timeout functionality.
des added a commit: rG589cef5d5151: libfetch: Restore timeout functionality.Wed, Feb 18, 6:42 PM
cperciva added a commit: rG8755b5f3a590: libfetch: Restore timeout functionality.Thu, Feb 19, 7:28 PM

Revision Contents
Changeset List

PathSize
lib/
libfetch/
11 lines

Diff 172158

View Options

lib/libfetch/common.c

Loading...